From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form Date: Sat, 12 Sep 2020 11:48:21 -0400 Message-ID: References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33559"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 12 17:50:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH7my-0008a2-6g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 17:50:08 +0200 Original-Received: from localhost ([::1]:45478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH7mw-0001Yf-NK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 11:50:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH7ms-0001YZ-6a for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 11:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kH7mr-0001dI-Tq for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 11:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kH7mr-00068C-Rk for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 11:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Sep 2020 15:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43329-submit@debbugs.gnu.org id=B43329.159992574823494 (code B ref 43329); Sat, 12 Sep 2020 15:50:01 +0000 Original-Received: (at 43329) by debbugs.gnu.org; 12 Sep 2020 15:49:08 +0000 Original-Received: from localhost ([127.0.0.1]:48851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH7m0-00066s-79 for submit@debbugs.gnu.org; Sat, 12 Sep 2020 11:49:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH7ly-00066Q-Lj for 43329@debbugs.gnu.org; Sat, 12 Sep 2020 11:49:07 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 11DB9441053; Sat, 12 Sep 2020 11:49:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C55E8440F4B; Sat, 12 Sep 2020 11:48:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599925702; bh=5uNRN5ATjscUUH7paBsECIuEieRCj1HPHszNdFgCMGo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Jj6LsgLZ9dL6j0Gon9cDO7jfUnHKOmsXr8rxzzKiVa2rf2RbQQ5a343/kiwM3v8wf 8MMF9LlDMKrpWE6ySthJ+BAk8IF3MTuOy/mVH9FmuAvi55EVt436+t0PRoxgbjWAHI 6vDjPzkIxUM/M1E+KCV9YK7uO74Zbn046lFWNaAOm58LxS2V4SyrGkBMjgY1FG6cyP us7XE3+PBlDVJ6G5CyuumEkh0hHTgjRxvxV4jsbNLdyoITVsh3LW/Do0Ug9SKYrMWg zRlUgEYAm2pDkKzKrVB06RZP9veEOCAj3UZumgv7G7QDoGct28WDzpLWRX9yfNbI2g jAi1swII91iyA== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6F383120793; Sat, 12 Sep 2020 11:48:22 -0400 (EDT) In-Reply-To: <87h7s32ooe.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Sep 2020 13:57:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187902 Archived-At: > Would something as simple as the following (which fixes this use case) > be the correct fix? It only indents these forms as macros if they are > top-level... It obviously has the downside of not indenting properly those definitions which are not at the very-top level. E.g. definitions inside an `eval-when-compile` or other. Stefan