From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el Date: Wed, 26 May 2021 17:28:48 -0400 Message-ID: References: <2ebf9ed0-bd5d-8107-9d22-61e56f29c02a@daniel-mendler.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13141"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48572@debbugs.gnu.org, joaotavora@gmail.com To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 26 23:52:06 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm1Rd-00038x-N1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 May 2021 23:52:05 +0200 Original-Received: from localhost ([::1]:39512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lm1Rc-0008LR-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 May 2021 17:52:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm16I-0003o7-9L for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 17:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38503) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lm16I-0005eE-0D for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 17:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lm16H-0004E4-PS for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 17:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 May 2021 21:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48572 X-GNU-PR-Package: emacs Original-Received: via spool by 48572-submit@debbugs.gnu.org id=B48572.162206454716164 (code B ref 48572); Wed, 26 May 2021 21:30:01 +0000 Original-Received: (at 48572) by debbugs.gnu.org; 26 May 2021 21:29:07 +0000 Original-Received: from localhost ([127.0.0.1]:50049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm15O-0004Cd-I8 for submit@debbugs.gnu.org; Wed, 26 May 2021 17:29:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm15J-0004C5-17 for 48572@debbugs.gnu.org; Wed, 26 May 2021 17:29:04 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6C82C100222; Wed, 26 May 2021 17:28:55 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BB44B100091; Wed, 26 May 2021 17:28:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622064529; bh=bjo5sIitYlXZwBG/yaQ8V7D7I/bhiw5iDVCA8N6Jxg8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=B55po3TNGM4dORF/lunB9As4pwsNh6o1TEm2Mi8gbF/Np7MXiDsVkJ9cjUeJIjyir RKm+6nB1f9iC6L0JP7oW8RWpJGFXowyym3/9t5lgNgEiGGuB5Czs1/OpyzIT3S04/p +W5nY9A1P9Yp/9W658pso30wCHuwXvf2oq8gPHAdifkfXQCRwcw9xzYCPAOj+Ynrsg hfOtIYQjTU5jh1T+flmA7foIs1FRQPAGkorNY/JujGUr0Ifhci+FsipOteQbnkbRtG kPx/CjyAkDhBHQCdCQ/KTAkRoQD1KBjq676ROCqyXnivw5/Z5/UvW9GKkgked5j+21 KhtqEF7mlM/Ew== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 806D9120A55; Wed, 26 May 2021 17:28:49 -0400 (EDT) In-Reply-To: (Daniel Mendler's message of "Sun, 23 May 2021 21:58:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207319 Archived-At: >> The "passthrough" (elsewhere called "backend") completion-style is >> definitely something we need to add, yes. But what it should do is pass >> all the args from `completion-all/try-completions` to the table and let >> the table do *all* the work, i.e. let the completion table implement the >> completion-style methods. But we shouldn't call `all-completions` or >> `try-completions` for that. Instead we should call the completion-table >> directly, as is done for the `completion-boundaries` method. > But `all-completions` and `try-completion` already calls the table > directly if the table is indeed a table. Yes, they do, but if you call them, then *you* don't: they call the table in their own way for their own purpose (e.g. for `all-completions` they call it to get all the completions matching a given prefix and that's it, whereas the whole point of `passthrough` is to be able to fetch matches based on other criteria (defined by the completion table)). > Basically `all-completions/try-completion` themselves are already > "passthrough" modulo some calling convention. > Am I missing something? Passthrough is about passing the completion-style API directly to the backend. `all-completions` is part of the backend API, not the completion-style API. Stefan