From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59347: 29.0.50; `:family` face setting ignored Date: Wed, 07 Dec 2022 19:27:28 -0500 Message-ID: References: <83tu2t4ie9.fsf@gnu.org> <7cc9e03786e324ff82ef@heytings.org> <83bkp04gjl.fsf@gnu.org> <83leo42vm9.fsf@gnu.org> <0d1ea3007fd94b7ae0b1@heytings.org> <83r0xv1649.fsf@gnu.org> <0d1ea3007f532a493429@heytings.org> <83cz9f12bh.fsf@gnu.org> <835yewleyn.fsf@gnu.org> <83tu2b9rlx.fsf@gnu.org> <83k0347gtu.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27321"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 59347@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 01:28:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p34lt-0006u1-9Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 01:28:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p34lf-0004n5-H5; Wed, 07 Dec 2022 19:28:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p34le-0004mw-Rl for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 19:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p34le-0006gW-Jn for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 19:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p34ld-00052c-Uo for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 19:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 00:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59347 X-GNU-PR-Package: emacs Original-Received: via spool by 59347-submit@debbugs.gnu.org id=B59347.167045926619371 (code B ref 59347); Thu, 08 Dec 2022 00:28:01 +0000 Original-Received: (at 59347) by debbugs.gnu.org; 8 Dec 2022 00:27:46 +0000 Original-Received: from localhost ([127.0.0.1]:53092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p34lN-00052N-Lo for submit@debbugs.gnu.org; Wed, 07 Dec 2022 19:27:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p34lE-00052H-QF for 59347@debbugs.gnu.org; Wed, 07 Dec 2022 19:27:43 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 54ECF44287F; Wed, 7 Dec 2022 19:27:31 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C9A4E44287C; Wed, 7 Dec 2022 19:27:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670459249; bh=HzCD5aDVrW19Rwc+4TNWrDzQ+njzJPVkMPc5NgitQ1Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=idkg5k/po7pn3x9c0014evreh6x8DNcaGUCmG3kHrt9C188hSZlIDEyfFF7br1eop nkC4ze+y2Jwf4oMHHhyAqs1BVs/1Rkj2huYqpMmCizcB0tpSWsjCCuu1p4KHV409G2 RHxM4ctmG26iwl55MLlrXffkEuLWRDAIQwl9Zh3eXlr/lpzQ9QCXS9pI0FLxHCW+dJ re++fjB4oAup61mn4EsmW8BJfqDAc08HB2F6MZuTWGS3LhCrBcFsExGhZMdVGGRdKg ehpPaQ0W1dBz4rwM+6FTHXpxhfxF1zgdBNu7mx73yhhWM3glXfPy+qljSu4iLDWQC9 E1eafwqyZESRA== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9F59F122557; Wed, 7 Dec 2022 19:27:29 -0500 (EST) In-Reply-To: (Gregory Heytings's message of "Wed, 07 Dec 2022 23:19:57 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250229 Archived-At: >> My question was not about this basic relative importance, it was about >> something else: when none of the fonts of the given FAMILY fits the font >> spec, why do you consider keeping the family to be more important than >> keeping the weight? > I don't understand your question. If we agree that there is an order of > importance in the attributes of a font spec, Why should we agree on that? When I specify the `:family` property on the `variable-pitch` face, I definitely want it to take precedence over the `:weight` of the default face, yes. But when I specify the `weight` property of the `bold` face, it's not clear at all that the `:family` of the default face should take precedence over the `:weight` of the `bold` face. FWIW, I've been running with your patch and I like the result. I think it's better overall, but I suspect that we still have a fundamental problem with this notion of precedence/ordering. Maybe the ordering should depend on the "stacking order" of the faces and their properties. I.e. instead of merging `bold+variable-pitch+default` to get a set of properties on which we apply a globally-imposed ordering, we could keep track of the relative ordering of the properties: `bold` was on top, so the `:weight` property comes first, then came `variable-pitch` so its `:family` property comes second and the second comes afterwards. So `bold+variable-pitch+default` could result in a different font than `variable-pitch+bold+default` even if the combined properties (i.e. the merged face) are identical. Stefan