From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Wed, 04 Jan 2023 13:02:37 -0500 Message-ID: References: <87o7ri74qv.fsf@localhost> <9bc9c69ac20a37ded741@heytings.org> <9bc9c69ac282c0148962@heytings.org> <87h6x9mgdv.fsf@localhost> <838rij23by.fsf@gnu.org> <83zgazznau.fsf@gnu.org> <83mt6yz7se.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60467@debbugs.gnu.org, acm@muc.de, Eli Zaretskii , yantar92@posteo.net To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 04 19:03:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD86p-0004wB-FB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Jan 2023 19:03:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD86a-0005d2-QP; Wed, 04 Jan 2023 13:03:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD86R-0005cU-N6 for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 13:03:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pD86Q-00062Y-78 for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 13:03:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pD86Q-0003Ja-2G for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 13:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.167285536812720 (code B ref 60467); Wed, 04 Jan 2023 18:03:02 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 4 Jan 2023 18:02:48 +0000 Original-Received: from localhost ([127.0.0.1]:49524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD86C-0003J3-Bp for submit@debbugs.gnu.org; Wed, 04 Jan 2023 13:02:48 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD86A-0003Is-Tu for 60467@debbugs.gnu.org; Wed, 04 Jan 2023 13:02:47 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6879C4400F7; Wed, 4 Jan 2023 13:02:41 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CEE2F441420; Wed, 4 Jan 2023 13:02:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672855359; bh=5VUJMTjtuw9hAI9e+bS056FdBzzIV/ADrWZyp9bs1zs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JUcUVlBK7gXIGzqIT4XeEnNfsPTC7kWp3MmCFiIVXIx2wYLw1qE+/Plmhh7kfb5GZ VZ6h/lXw0XASiu12oDQPftPL2RSwzlXTnAt05pLFVsTi4w8qCHkTeOp9HQs+ZYUYjk ougqS9FV8zvJTr8wPQA5Px9JrtearryoFJqad2LBaRCLKwjSP5wgz0qeM8NVtVA6QB eOU3Cp7Cc4IQHMRshGIbuwaCvOmYqm8tsJveV4a3lS510tZrssUa4LQG4WHTVmD9u3 srF7mQGiJxpMBYfLJWJcAa8SVl9ReW/Qg2Y9tKA53Rw4SXZDXY9kp8E17kmXZ22Zdf gOxrGhcchHZlQ== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 95706120978; Wed, 4 Jan 2023 13:02:39 -0500 (EST) In-Reply-To: (Gregory Heytings's message of "Wed, 04 Jan 2023 14:39:40 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252515 Archived-At: >>>> For the loop currently in `subr.el` I think the (cdr ptr) is OK because >>>> we use the `setcdr` to truncate the list, so that last cons (whose `cdr` >>>> may be nil) will be in the list included in the (apply ....) entry. >>> >>> Indeed, now I see it, and I think (without being 100% sure) that it's >>> OK. It's yet another obscure point of the original code, though. >> >> I hope all these revelations will find their way into comments to this >> tricky code. >> > > Well, I hope this tricky code will be replaced by the non-tricky code > I proposed, in which none of these obscurities exist... ;-) My hope is that we can just remove the timestamp special case, in which case we can keep the current code mostly unchanged. Stefan