From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations Date: Thu, 18 May 2023 09:37:57 -0400 Message-ID: References: <2eb987c6-0aec-55df-db4e-ef95557ab809@daniel-mendler.de> <83zg64zhyx.fsf@gnu.org> <31f17ffe-8070-4259-03d2-2c63e5cc5ee9@daniel-mendler.de> <3e8bced6-28f8-a0d0-3a74-2907bc241d53@daniel-mendler.de> <83sfbuw639.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25025"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Daniel Mendler , liuhui1610@gmail.com, 61283@debbugs.gnu.org, arstoffel@gmail.com, jporterbugs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 18 15:39:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzdqm-0006Jj-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 May 2023 15:39:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzdqS-0004dU-7n; Thu, 18 May 2023 09:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzdqQ-0004ct-AB for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 09:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzdqQ-0007p5-1h for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzdqP-0001tz-Ti for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 09:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61283 X-GNU-PR-Package: emacs Original-Received: via spool by 61283-submit@debbugs.gnu.org id=B61283.16844170867233 (code B ref 61283); Thu, 18 May 2023 13:39:01 +0000 Original-Received: (at 61283) by debbugs.gnu.org; 18 May 2023 13:38:06 +0000 Original-Received: from localhost ([127.0.0.1]:52726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzdpW-0001sb-9p for submit@debbugs.gnu.org; Thu, 18 May 2023 09:38:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzdpU-0001s3-Vl for 61283@debbugs.gnu.org; Thu, 18 May 2023 09:38:05 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A16764413FF; Thu, 18 May 2023 09:37:59 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 54E2E44082B; Thu, 18 May 2023 09:37:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1684417078; bh=Ca7EBDfJX+DJ7BrKK3fI93M9DCQ/zG6alD9rvEsAuhM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dBYSFJTeVRjwdUZPvCofX08UDtCgVfEf5bkA5ElXp7rjtscnXaxexxO71r4zU7UHi DFG7xeFylCPbW4jLClb1qkeVnP8K/T2nWgfomO7eP/cm9sD3ZxmnqsE8tskZD4K3oV fjrACsrLi4ynx2Xl1eg/K+HnBhhb8vLbVG47Vbp4F4q0akoNTkWgZ2gNl1uJoyO2Bt XUS7wkwljm5KxYx8do26RpzTMGyWbzehjjEylDSbKYeH1QieroUxhpBvSgg6SeEn2n JCB48hPocuYwhG2CWIAs1q2R2sc5k4vbZj8RmVUTR+CHMJQ6ozofVGh3zYsoK3LCQz R5n9z/Z9bAoPA== Original-Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0893F120317; Thu, 18 May 2023 09:37:58 -0400 (EDT) In-Reply-To: <83sfbuw639.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 May 2023 08:39:54 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261930 Archived-At: >> But this means that the following simple patch to `completion--twq-all' >> also fixes the issue. It ensures that the original string is preserved >> in the common case where string quoting was ineffective. This approach >> may be better than refactoring pcomplete.el. The patch may even be safe >> enough for emacs-29. Sounds like a good enough "quick hack" for Emacs-29, indeed. I don't think it's a good long term solution, tho, because it's a hack in the generic `completion-table-with-quoting` code added specifically for `pcomplete-from-help`. I'd *much* prefer a hack which touches only `pcomplete.el`. [ Maybe I'd be OK with a solution in the generic code but only if it's an actual robust solution, rather than a hack. ] > Why do you think it will be safe for emacs-29? Because it replace a string with one which is `equal` to the other. There is of course a risk that the string object is later mutated under the assumption that it's a fresh new string, so it's not 100% safe in theory, but I'd judge it to be very safe. > And why do we have to fix this in Emacs 29.1? We don't. From where I stand the main interest of the `pcomplete-from-help` feature is the completion itself rather than the additional help it can provide, so I'm perfectly fine with not fixing it for Emacs-29.