From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67196: M-: uses a wrong value of debug-on-error when it is nil. Date: Fri, 24 Nov 2023 16:25:11 -0500 Message-ID: References: <83a5rfq6i2.fsf@gnu.org> <83ttpbdm2f.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67196@debbugs.gnu.org, Eli Zaretskii To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 24 22:26:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6dgv-0007SK-FU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Nov 2023 22:26:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6dgV-0007RH-9Y; Fri, 24 Nov 2023 16:25:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6dgT-0007Qt-Qq for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2023 16:25:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6dgT-0001o6-IB for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2023 16:25:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6dgY-00061Y-6i for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2023 16:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Nov 2023 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67196 X-GNU-PR-Package: emacs Original-Received: via spool by 67196-submit@debbugs.gnu.org id=B67196.170086112523082 (code B ref 67196); Fri, 24 Nov 2023 21:26:02 +0000 Original-Received: (at 67196) by debbugs.gnu.org; 24 Nov 2023 21:25:25 +0000 Original-Received: from localhost ([127.0.0.1]:37353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6dfw-00060D-W3 for submit@debbugs.gnu.org; Fri, 24 Nov 2023 16:25:25 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6dfu-0005zx-LA for 67196@debbugs.gnu.org; Fri, 24 Nov 2023 16:25:23 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8AD0A100068; Fri, 24 Nov 2023 16:25:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700861111; bh=lz6waaW0AxTcFQrhUcv3yiCJ/KM31WPPIYUnXgl85aE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=e9YqgxgHOrETSpSsyM70pCsEI5TDlbut2Eg3oZEbobfDCxpIRbArIhE0x+j4I/3OM mckpU3jvuHwkbAd1rntBYSnM8rybMo1evN1iRIaUhyb+mw0UU3LGOEtEj5F7j2+t6Q L0qv+e/TWinit4xTRu2TFFJkYOhLQwKXceU0/uHsyHPuvE0cshDfbhw6V9rpA7q+Ga MUjPnCgN3N+xhV64kIkSkc4EdeAtwzTfl8iNdQ5miLn6Xv4aujEEABY9y+5tRD0maF GsG/McgPxi72jj2oTq/YwudLP6g4nbNte1rK7I3tyLOkDlzg01Uoh29wp7iiu+oB2h AUDS8ZPZlN4+Q== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D9CB1100033; Fri, 24 Nov 2023 16:25:11 -0500 (EST) Original-Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B67BA120191; Fri, 24 Nov 2023 16:25:11 -0500 (EST) In-Reply-To: (Alan Mackenzie's message of "Fri, 24 Nov 2023 20:54:45 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274891 Archived-At: > + (let* ((debug-from--eval-expression eval-expression-debug-on-error) > + (result (values--store-value > + (eval (let ((lexical-binding t)) (macroexpand-all exp)) t))) > + (print-length (unless no-truncate eval-expression-print-length)) > + (print-level (unless no-truncate eval-expression-print-level)) > + (eval-expression-print-maximum-character char-print-limit) > + (deactivate-mark) > + (out (if insert-value (current-buffer) t))) > + (prog1 > + (prin1 result out) > + (let ((str (and char-print-limit > + (eval-expression-print-format result)))) > + (when str (princ str out)))))) So you kicked the can a bit further down the road. The next bug report will be that `M-: debug-from--eval-expression` does not return the expected value. FWIW, the other way I came up to circumvent the problem is to test the shape of the expression to evaluate and only use `eval-expression-debug-on-error` when the expression is not a mere symbol (for which the backtrace would presumably not be interesting anyway). But then we get the weird situation where `M-x debug-on-error` can return nil but `M-x (list debug-on-error ...)` returns a list that starts with t. I think I'd rather keep the current code, whose semantics is actually simpler. Stefan