From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Sun, 17 Dec 2023 19:24:51 -0500 Message-ID: References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87bkdq3nw6.fsf@web.de> <875y3yx221.fsf@breatheoutbreathe.in> <87pm260wh9.fsf@web.de> <87v8bx48ww.fsf@breatheoutbreathe.in> <87msx8sbpv.fsf@web.de> <87bkdoh1gy.fsf@breatheoutbreathe.in> <87h6ngs85e.fsf@web.de> <87ttr7nzyj.fsf@breatheoutbreathe.in> <83pm1u6f8l.fsf@gnu.org> <83fs2o2wb0.fsf@gnu.org> <83v8bj2794.fsf@gnu.org> <83r0m70zwp.fsf@gnu.org> <83sf6mzcz6.fsf@gnu.org> <878r72odzs.fsf@breatheoutbreathe.in> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3648"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: michael_heerdegen@web.de, Eli Zaretskii , philipk@posteo.net, 66187@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 18 01:25:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rF1Rm-0000i8-Hk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Dec 2023 01:25:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rF1RO-0007uV-9A; Sun, 17 Dec 2023 19:25:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rF1RN-0007uJ-7o for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 19:25:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rF1RM-0008Te-Vr for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 19:25:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rF1RO-0007Be-1M for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 19:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Dec 2023 00:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66187 X-GNU-PR-Package: emacs Original-Received: via spool by 66187-submit@debbugs.gnu.org id=B66187.170285909927610 (code B ref 66187); Mon, 18 Dec 2023 00:25:02 +0000 Original-Received: (at 66187) by debbugs.gnu.org; 18 Dec 2023 00:24:59 +0000 Original-Received: from localhost ([127.0.0.1]:59188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rF1RK-0007BG-VN for submit@debbugs.gnu.org; Sun, 17 Dec 2023 19:24:59 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rF1RK-0007B4-1O for 66187@debbugs.gnu.org; Sun, 17 Dec 2023 19:24:58 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8212980D2A; Sun, 17 Dec 2023 19:24:50 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702859089; bh=e9eDFIAwJm1dJtt5KtA22R6MsruNfTiTTyfHZmo4uYU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JrVq309uxvkGWG7rtbVEFf7pkakFrZGnrbX9MrjAVyIhAcK2EABpCmH8O0eU0J5qU UW4ZxPdGPAKNTcRcbN6AeAKZBtu7szsN8CLfIBdd4ylYIo3awTUOdBitknIgL1tcor ZLbp9bA/z9XWrYlBdOC2ddUFUrsoRSg44evYDj2GDqMHeBW/pGeb4DKm476ly9vLIB Q1K3KNZ7hvOjC58LiN25NKSKB50k56JQ6jKF81aE2LqA7fwpj0bKoivNJ4tlICFu0T w1sSt24Df7SLQ+BInxkzmBP2s4bRsf4v5Dm1jTQ+xybcNtwY/F7N/dWJj+0VY3z9U+ ySfYT4kzk85yg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5580A801CC; Sun, 17 Dec 2023 19:24:49 -0500 (EST) Original-Received: from alfajor (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 18E1C120E2C; Sun, 17 Dec 2023 19:24:49 -0500 (EST) In-Reply-To: <878r72odzs.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 12 Nov 2023 13:26:10 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276449 Archived-At: > Here's another potential solution. While the attached patch seems to > work, I'm not sure that minibuffer-completion-confirm should be checked > in completion--do-completion instead of completion--complete-and-exit. It's definitely better to check it in `completion--complete-and-exit` (which is about exiting and thus related to whether the content is acceptable) than in `completion--do-completion` (which is just about completion). The patch looks OK, thanks. We could make it call `completion-function` instead of saying "no match" (after all, it has "complete" in its name), but it comes with its own set of problems. Stefan