From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70139: [PATCH] Improve key-translate to support removing translations Date: Sun, 07 Apr 2024 10:45:28 -0400 Message-ID: References: <87v850t7nz.fsf@gmail.com> <20240402190246.1824023-1-charmitro@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5083"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70139@debbugs.gnu.org To: Charalampos Mitrodimas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 07 16:46:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtTma-000160-6I for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Apr 2024 16:46:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtTmP-0001PZ-TO; Sun, 07 Apr 2024 10:45:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtTmN-0001PG-Ua for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 10:45:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtTmN-00054F-MF for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 10:45:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtTmU-0000ls-E3 for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2024 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70139 X-GNU-PR-Package: emacs Original-Received: via spool by 70139-submit@debbugs.gnu.org id=B70139.17125011442852 (code B ref 70139); Sun, 07 Apr 2024 14:46:02 +0000 Original-Received: (at 70139) by debbugs.gnu.org; 7 Apr 2024 14:45:44 +0000 Original-Received: from localhost ([127.0.0.1]:44301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtTmB-0000jv-NM for submit@debbugs.gnu.org; Sun, 07 Apr 2024 10:45:43 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtTmA-0000jk-GD for 70139@debbugs.gnu.org; Sun, 07 Apr 2024 10:45:42 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 43E361000FC; Sun, 7 Apr 2024 10:45:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1712501129; bh=IJAafrJ7vyBjKzCeaU5rXNqtl7x8TqkKMJRKl1Q25KQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=J0gbxI01bUMw8AzniLryQZN/r1FO/HR3Hu8YegOJ/1ide1/YUebeLKU3qlugrTzRJ yDLm0agfD1rN3b1sW5cf9fxpC0TRw3T3ywrypFTWNUKF0IFhSE08DzkNHBl4f09nkG 2rVpkGtz//9IovxafoL9qrv0TFxhNdJWoE+aUlTnfVh7JDcU8G9jQ3vvWpTXdSBoPC KLc/GmRTrIO0hdoAvPL5GEhRy64LgiRtlSoqQMEMEZ1B6LPIz+wfQiu7PwYSWEEOOy 9DsYCpBwNT9fI8kALs5M8cg8KwpcbRHPlCaG9TriV4qIP61oDcMWMk1MUcLfRQ5pbH w8oaKDIsY0PGA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3DC1A10004A; Sun, 7 Apr 2024 10:45:29 -0400 (EDT) Original-Received: from alfajor (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 152231201BF; Sun, 7 Apr 2024 10:45:29 -0400 (EDT) In-Reply-To: (Charalampos Mitrodimas's message of "Sat, 06 Apr 2024 17:18:29 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282872 Archived-At: > + (lambda (form) (keymap--compile-check from (and to to)) form))) ^^^^^^^^^^^ ?? > (keymap--check from) > - (keymap--check to) > - (or (char-table-p keyboard-translate-table) > - (setq keyboard-translate-table > - (make-char-table 'keyboard-translate-table nil))) > - (aset keyboard-translate-table > - (aref (key-parse from) 0) > - (aref (key-parse to) 0))) > + (when to > + (keymap--check to)) > + (let ((from-key (key-parse from)) > + (to-key (and to (key-parse to)))) > + (when (> (length from-key) 1) > + (error "FROM key %s is not a single key" from)) > + (when (and to (> (length to-key) 1)) > + (error "TO key %s is not a single key" to)) I'd check `=` while at it (if length is 0 the error is caught by `aref`, but it's a less helpful error). Stefan