From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70820: [PATCH] Editable grep buffers Date: Wed, 14 Aug 2024 07:37:53 -0400 Message-ID: References: <87seytlhcq.fsf@gmail.com> <86pltxa40q.fsf@gnu.org> <87jzk5kmwk.fsf@gmail.com> <86ikzoa51h.fsf@gnu.org> <878r0klcp1.fsf@gmail.com> <864jb89zwq.fsf@gnu.org> <87wmo3jmws.fsf@gmail.com> <87fruny6xe.fsf@gmail.com> <86le47eafb.fsf@gnu.org> <86pltjceft.fsf@gnu.org> <86ikzbcces.fsf@gnu.org> <87le1lj4pv.fsf@gmail.com> <87bk1vzuw1.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7348"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 70820@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 14 13:38:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1seCL4-0001jK-FW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Aug 2024 13:38:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1seCKi-0008Fk-IW; Wed, 14 Aug 2024 07:38:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seCKh-0008Fc-RD for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 07:38:27 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1seCKh-0000PB-Ii for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 07:38:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=CFtGsqp3kH7Zbz4Ro/9frwaq1jw3QPQITR97VsTKVBU=; b=NrwFvr+t9BupHCFtVObtzQRb0n38MbWDEV0wHKBEknl8ADbRaa24fUmfs3Sw9B5THuOq0rXkJ9opQI8s+jG+6bOrRnCYA/5aqTKm0G3McaXQkWPzt+quTEcGgIVcTA7dhdF9r59ELNkUKSX9iD5k8gl5/0jb3ku+fD3XfMR+bf9dLQ7OVtxLm+sgo7R1fSHQcGTzDmxBmQHNLLGEZgfSrqvVwYKtNiproKVSBRm8Li871PBaA5d/iB5fEKLo2x/f0HzpoCKzenkNI64G+6KRc/DwVU5Lqyx+3oq1HwdvBBHWn79JvDzUdqBSoIeM/hj3270v6N+QvdcT9N6WAhws5Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1seCLG-00019h-7Z for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 07:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Aug 2024 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70820 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70820-submit@debbugs.gnu.org id=B70820.17236355214387 (code B ref 70820); Wed, 14 Aug 2024 11:39:02 +0000 Original-Received: (at 70820) by debbugs.gnu.org; 14 Aug 2024 11:38:41 +0000 Original-Received: from localhost ([127.0.0.1]:46326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seCKu-00018d-IA for submit@debbugs.gnu.org; Wed, 14 Aug 2024 07:38:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seCKt-00018I-0u for 70820@debbugs.gnu.org; Wed, 14 Aug 2024 07:38:39 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1AC77440493; Wed, 14 Aug 2024 07:37:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1723635475; bh=Tn2OSw5cS5zfOSmZ8cbt+t+2+jczVmCXuX+iawoaIy4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NK9/CSXk5XTEYzo/MvVQWnMKULZsRF4SZui9OrtrFj+wfqkfQ9UMZF7KZ+1txv4zu dSNCnCFKKJCqksdGLKjg5PxuAGFEsHichqX3vZTvDn+b036pVeY3AJ+F7AsM0V3TAv Uw00PbkSNTAUy59nJ5Qdn3j+pgb91jrKMiRwN+Gu10WaQWCiRUps2FPX8qE/mjmRNB Tuv6bdYfBlqDtgz/KJEDSFS15BR5Btjw68xu58ki/9tqO66O5KJmH46rdckEtVjlBH o5xJkI6c4gbxUQutm8+3lczCXbfznLShwqjHB9cRXU3c1M6TpGkYzLBj/pJx6eCWrN oJNSrU2HPA4BQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 893C5441BF1; Wed, 14 Aug 2024 07:37:55 -0400 (EDT) Original-Received: from pastel (unknown [216.154.9.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5AD1112046B; Wed, 14 Aug 2024 07:37:55 -0400 (EDT) In-Reply-To: <87bk1vzuw1.fsf@gmail.com> (Visuwesh's message of "Wed, 14 Aug 2024 08:13:42 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290130 Archived-At: >> Are there any changes in this code, or is it "verbatim" the code >> extracted from `compilation-next-error-function`? > It is extracted verbatim from compilation-next-error-function. Great, thanks. >>> +(defvar grep-edit-mode-hook nil >>> + "Hooks run when changing to Grep-Edit mode.") >> It's just "Hook" because `grep-edit-mode-hook` is a hook. Hooks contain >> functions, so when you run a hook, the corresponding functions are called. > Ah, I was under the impression that the functions were also referred to > as hooks. You're far from the only one: it's a common confusion, and it's frequent to see docstrings which encourage that confusion. > If everyone is okay with the current patch, I can get to writing the > NEWS entry and updating the manual. Thanks. +1 Stefan