From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74091: 31.0.50; string-pixel-width in mode line disables region Date: Sat, 09 Nov 2024 17:11:19 -0500 Message-ID: References: <86y1254owq.fsf@gnu.org> <86ldy54m2g.fsf@gnu.org> <86ed3w33g1.fsf@gnu.org> <8634k0mkgy.fsf@gnu.org> <86ttcgl1f0.fsf@gnu.org> <86ses0l0g3.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36351"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: me@eshelyaron.com, 74091@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 09 23:12:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9tgu-0009Iw-Ei for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Nov 2024 23:12:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9tga-0007Y8-SN; Sat, 09 Nov 2024 17:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9tgZ-0007Xu-4m for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 17:12:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9tgY-0000Do-Si for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 17:12:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=CrkFdwZipS7oMdNPUfyd5aiLz8DkP28aRKtxFTvC8Dw=; b=cWPoiWLyHkn21YcnZ3L3FEyP/LhpEjONfpH6rISLmv5MlJGMFlXZ5sQYZHArOF+D3WMHPGPjfFIIEh/M1Ek3xItT7JGyvXUuicJ9YYMwc1Wf54YvWoka1WBc+5pR8cOFxji3TYDyHZBgz/NgF+fBU3bYsM0m2UBHp2KVfA4/ZDbSXCiW2U+Xgiyu1lbshcHxMksBxgtnn3JQ/TZDfoLGCmUr5pFBvv0wM9LhN8yGAWTtX3fpFXbff256OYiFSZJQxdJpON9Mowgltu8LQOU13Gwgt1KUX53FSoCjRGB4U7ylE6xLXOpeX13DVhGwQ5RlAjzSnbS/LhuqtUWxCzSpAw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9tgY-0002I3-7v for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 17:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2024 22:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74091 X-GNU-PR-Package: emacs Original-Received: via spool by 74091-submit@debbugs.gnu.org id=B74091.17311902918761 (code B ref 74091); Sat, 09 Nov 2024 22:12:02 +0000 Original-Received: (at 74091) by debbugs.gnu.org; 9 Nov 2024 22:11:31 +0000 Original-Received: from localhost ([127.0.0.1]:54732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9tg2-0002HF-Ka for submit@debbugs.gnu.org; Sat, 09 Nov 2024 17:11:30 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9tg0-0002Gz-C1 for 74091@debbugs.gnu.org; Sat, 09 Nov 2024 17:11:29 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B282644105A; Sat, 9 Nov 2024 17:11:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1731190280; bh=k/lZRQ2G98fzgNchZ7/tTEWWuaXfgBL1fFe8EyClXvI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=F9whLXoaEerZt0pfdUC9OqVQmtFKq0i3y03MzhQ9JFGJtqaynwSTLirS2G2onoKQw KHQtVjA4/yFbnbwYLs/L5Q2B+w8CTtG+UtHAbgUiVPh+CnmC2VUMQ3fup+de+2O5Fe 1qvxcUe1uKH25vZHYih56UTbUnReNi76nkk2hVepF1khAPH5jFiTJtwZTMkStEYJwa lNIoHr49N6N7u1v9qqnniUSLZ3OPMvBSD5W3jOORMH68k7K80mUMC97d9CfOSf1UFT dwk64Hl5hECt1fRfG5P9QyQHNkELWktkyzXGILcWv6h89eMCuYVevdXGPIi+lxRt3r mHKjm5yS70v0g== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CDFC844067F; Sat, 9 Nov 2024 17:11:20 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A2426120352; Sat, 9 Nov 2024 17:11:20 -0500 (EST) In-Reply-To: <86ses0l0g3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Nov 2024 20:35:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295159 Archived-At: > I think we should instead ignore the permanent-local property of > variables. How about the patch below? Funny: I went through 3 different versions of a patch and ended up with basically the same patch as yours. > @@ -1170,7 +1171,7 @@ reset_buffer_local_variables (struct buffer *b, bool permanent_too) > swap_in_global_binding (XSYMBOL (sym)); > } > > - if (!NILP (prop)) > + if (!NILP (prop) && permanent_too) > { > /* If permanent-local, keep it. */ > last = tmp; This should be an || rather than an &&, no? Stefan