unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: me@eshelyaron.com, 74091@debbugs.gnu.org
Subject: bug#74091: 31.0.50; string-pixel-width in mode line disables region
Date: Sat, 09 Nov 2024 17:11:19 -0500	[thread overview]
Message-ID: <jwvldxsxdpi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86ses0l0g3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Nov 2024 20:35:40 +0200")

> I think we should instead ignore the permanent-local property of
> variables.  How about the patch below?

Funny: I went through 3 different versions of a patch and ended up with
basically the same patch as yours.

> @@ -1170,7 +1171,7 @@ reset_buffer_local_variables (struct buffer *b, bool permanent_too)
>  	      swap_in_global_binding (XSYMBOL (sym));
>  	    }
>  
> -          if (!NILP (prop))
> +          if (!NILP (prop) && permanent_too)
>              {
>                /* If permanent-local, keep it.  */
>                last = tmp;

This should be an || rather than an &&, no?


        Stefan






  reply	other threads:[~2024-11-09 22:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 17:27 bug#74091: 31.0.50; string-pixel-width in mode line disables region Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-30 14:59 ` Eli Zaretskii
2024-10-30 15:26   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-30 16:01     ` Eli Zaretskii
2024-10-31 11:09       ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 11:41         ` Eli Zaretskii
2024-10-31 12:24           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 14:35             ` Eli Zaretskii
2024-11-06  8:01               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-06 12:49                 ` Eli Zaretskii
2024-11-06 14:12                   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09 11:13                     ` Eli Zaretskii
2024-11-09 16:26           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09 16:37             ` Eli Zaretskii
2024-11-09 18:06               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09 18:14                 ` Eli Zaretskii
2024-11-09 18:35                   ` Eli Zaretskii
2024-11-09 22:11                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-11-10  5:50                       ` Eli Zaretskii
2024-11-10  6:50                         ` Eli Zaretskii
2024-11-10 10:42                           ` Eli Zaretskii
2024-11-10 16:46                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-10 19:17                               ` Eli Zaretskii
2024-11-10 20:19                                 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-11  3:22                                   ` Eli Zaretskii
2024-11-11  6:52                                     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvldxsxdpi.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=74091@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=me@eshelyaron.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).