unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 308@emacsbugs.donarmstrong.com
Subject: bug#308: vc-delete-file
Date: Fri, 23 May 2008 17:00:11 -0400	[thread overview]
Message-ID: <jwvk5hk21kh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <al8wy1f4bm.fsf@nyc-qws-005.delacy.com> (Sam Steingold's message of "Fri, 23 May 2008 11:06:05 -0400")

> first, vc-delete-file is available neither in any menu nor on any key.
> despite your claim to the contrary, this is a common command, used at
> least weakly in an active development environment.

I'm not sure who is "you", but for what it's worth, I agree it should be
available via some key-binding.  Even more so in vc-dir.

> second, when I invoke it with M-x, it requires that the file being
> removed is still present on disk.

That's a bug, indeed.  But I don't see any place in the code where
that's done on purpose.  Could you provide a recipe to reproduce the
problem?  It might depend on the backend.

> this requirement is absurd because when I decide to remove the file from
> the VCS, it is already long gone because I have to remove it to test the
> system without it

No need to argue that it's a bug, I agree.
[ For what it's worth, I'd recommend you vc-delete-file before doing
  your tests, tho.  After all, you can always undo it before committing
  if it turns out it was a bad idea.  ]

> Debugger entered--Lisp error: (error "File myfilename no longer exists!")
>   signal(error ("File myfilename no longer exists!"))
>   error("File %s no longer exists!" "myfilename")
>   revert-buffer(t t t)
>   vc-revert-buffer-internal(t t)
>   vc-resynch-window("myfilename" #<buffer convert_config.mli> t)
>   vc-resynch-buffer("myfilename" #<buffer convert_config.mli> t)
>   vc-delete-file("myfilename")
>   call-interactively(vc-delete-file t nil)
>   execute-extended-command(nil)
>   call-interactively(execute-extended-command nil nil)

> i.e., you just deleted it yourself - and now you are complaining that
> the file does not exist!
> I would rather expect kill-buffer instead of revert-buffer.

I've just changed the code to kill the buffer, indeed.
Thank you,


        Stefan






       reply	other threads:[~2008-05-23 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <al8wy1f4bm.fsf@nyc-qws-005.delacy.com>
2008-05-23 21:00 ` Stefan Monnier [this message]
2008-05-23 21:38   ` bug#308: vc-delete-file Dan Nicolaescu
2008-05-24  2:23     ` Stefan Monnier
2008-05-23 15:06 Sam Steingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk5hk21kh.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=308@emacsbugs.donarmstrong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).