From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: 753@emacsbugs.donarmstrong.com
Subject: bug#753: [Fwd: sh-script.el: indentation of ( )]
Date: Fri, 09 Jan 2009 12:24:02 -0500 [thread overview]
Message-ID: <jwvk594ieeg.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <ahbpuhvzq3.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 09 Jan 2009 00:02:28 -0500")
>> It doesn't matter. "done)" is not an entity in `sh', so we should not
>> treat it as one.
> Yes, but it is a useful shortcut to treat it as one IMO, since it
> gets the indentation "mostly right" for little effort.
It still gets it wrong for "done )". And it introduces bugs elsewhere.
I'm pretty sure it was not done on purpose: it's basically a bug that
accidentally does the right thing in some corner cases.
> I'm afraid I don't know how to fix it (indentation) properly, so I
> reopened this bug.
We know how to fix the OP's bug without re-introducing the bug that my
misguided patch tried to fix. So we should do that and close this bug.
Then we can open another bug about the "done )" case pattern since it's
a different bug.
Stefan
next prev parent reply other threads:[~2009-01-09 17:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <eqr67xumlz.fsf@fencepost.gnu.org>
2008-08-20 21:36 ` bug#753: [Fwd: sh-script.el: indentation of ( )] Daniel Pfeiffer
2008-08-23 0:12 ` Glenn Morris
2008-09-03 17:34 ` Glenn Morris
2009-01-07 4:47 ` Stefan Monnier
[not found] ` <jwvy6xnd8rf.fsf-monnier+emacsbugreports@gnu.org>
2009-01-08 8:00 ` Glenn Morris
2009-01-08 16:39 ` Stefan Monnier
2009-01-09 2:39 ` Glenn Morris
2009-01-09 3:58 ` Stefan Monnier
2009-01-09 5:02 ` Glenn Morris
2009-01-09 17:24 ` Stefan Monnier [this message]
2015-12-30 0:45 ` Andrew Hyatt
2016-01-01 2:19 ` Glenn Morris
2016-01-02 20:55 ` Andrew Hyatt
2008-09-06 19:10 ` bug#753: marked as done ([Fwd: sh-script.el: indentation of ( )]) Emacs bug Tracking System
2009-05-04 20:30 ` Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk594ieeg.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=753@emacsbugs.donarmstrong.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).