From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ian Eure <ian@digg.com>
Cc: 3233@emacsbugs.donarmstrong.com
Subject: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width
Date: Wed, 06 May 2009 21:34:13 -0400 [thread overview]
Message-ID: <jwvk54tits5.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87AAEBEC-E8DD-4BE0-A35A-9C0AEFB2F997@digg.com> (Ian Eure's message of "Wed, 6 May 2009 14:22:27 -0700")
> (let ((disp (frame-parameter frame 'display)))
Why not use `frame' directly? The `display' frame parameter is
fundamentally specific to X11 (although we kinds of try to make Emacs
pretend that it also exists under other GUIs).
> I don't know how (display-pixel-height) handles multihead displays, but it
> seems saner to explicitly pass the display the frame occupies.
The "display" you pass is just some string. So "right" way would be to
pass the corresponding terminal (i.e. (frame-terminal frame)), but
most/all the functions that operate on terminals accept frames as well
(since terminal object were only introduced in Emacs-23 as pat of the
multi-tty code, so frames were previously the canonical way to refer to
a display).
Stefan
next prev parent reply other threads:[~2009-05-07 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 18:49 bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width Ian Eure
2009-05-06 19:57 ` Stefan Monnier
2009-05-06 21:22 ` Ian Eure
2009-05-07 1:34 ` Stefan Monnier [this message]
2009-05-07 4:50 ` Ian Eure
-- strict thread matches above, loose matches on Subject: below --
2009-07-23 16:42 Adrian Robert
2009-11-23 16:49 Jimmy Yuen Ho Wong
2010-01-06 16:45 Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk54tits5.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=3233@emacsbugs.donarmstrong.com \
--cc=ian@digg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).