From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4804: 23.1; bookmark-bmenu-bookmark performances Date: Sun, 25 Oct 2009 11:12:57 -0400 Message-ID: References: <87my3fzx7l.fsf@tux.homenetwork> Reply-To: Stefan Monnier , 4804@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1256484453 7594 80.91.229.12 (25 Oct 2009 15:27:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Oct 2009 15:27:33 +0000 (UTC) Cc: 4804@emacsbugs.donarmstrong.com To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 25 16:27:26 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N2509-0003gM-Vk for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Oct 2009 16:27:26 +0100 Original-Received: from localhost ([127.0.0.1]:57282 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2509-0007ib-Bp for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Oct 2009 11:27:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2504-0007hi-Jp for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2009 11:27:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2500-0007g0-A8 for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2009 11:27:20 -0400 Original-Received: from [199.232.76.173] (port=45323 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2500-0007ft-0l for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2009 11:27:16 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36390) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N24zz-00038j-I6 for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2009 11:27:15 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9PFRDGo020135; Sun, 25 Oct 2009 08:27:13 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9PFK5la018826; Sun, 25 Oct 2009 08:20:05 -0700 Resent-Date: Sun, 25 Oct 2009 08:20:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 25 Oct 2009 15:20:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4804 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4804-submit@emacsbugs.donarmstrong.com id=B4804.125648358617894 (code B ref 4804); Sun, 25 Oct 2009 15:20:04 +0000 Original-Received: (at 4804) by emacsbugs.donarmstrong.com; 25 Oct 2009 15:13:06 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9PFD459017884 for <4804@emacsbugs.donarmstrong.com>; Sun, 25 Oct 2009 08:13:05 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkEANoH5EpLd/xb/2dsb2JhbACBT9JjhD8EiDQ X-IronPort-AV: E=Sophos;i="4.44,621,1249272000"; d="scan'208";a="48130926" Original-Received: from 75-119-252-91.dsl.teksavvy.com (HELO pastel.home) ([75.119.252.91]) by ironport2-out.pppoe.ca with ESMTP; 25 Oct 2009 11:12:58 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 36B668225; Sun, 25 Oct 2009 11:12:57 -0400 (EDT) In-Reply-To: <87my3fzx7l.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Sun, 25 Oct 2009 09:36:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sun, 25 Oct 2009 11:27:20 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32233 Archived-At: > 1) run a loop on all menu list to toggle filenames visibility. > 2) come back to the original place and get bookmark name with > buffer-substring > 3) run again a loop to toggle filenames visibility back. > That's very costly. Agreed, it's costly, brittle, and ugly. But your solution relies on a correspondance between bookmark-latest-sorted-alist and the buffer's content, even though this correspondance is nowhere enforced (i.e. future changes to the code are likely to break it, or manual buffer modifications could also break it). Much easier and more robust would be to put the relevant data directly in the buffer in the form of text-properties, so it can be extracted directly via get-text-property regardless of whether the filenames are hidden. Stefan