From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: bug#6010: 24.0.50; setting-constant enable-multibyte-characters
Date: Fri, 23 Apr 2010 12:16:24 -0400 [thread overview]
Message-ID: <jwvk4ryrwcv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <b4m633ir4jf.fsf@jpl.org> (Katsumi Yamaoka's message of "Fri, 23 Apr 2010 16:50:28 +0900")
> Debugger entered--Lisp error: (setting-constant enable-multibyte-characters)
> set-default(enable-multibyte-characters nil)
> mm-find-buffer-file-coding-system("~/bt.gz")
Thanks. The patch below should have fixed it,
Stefan
=== modified file 'lisp/gnus/mm-util.el'
--- lisp/gnus/mm-util.el 2010-03-15 01:38:28 +0000
+++ lisp/gnus/mm-util.el 2010-04-23 15:04:34 +0000
@@ -1239,6 +1239,9 @@
harmful since it is likely to modify existing data in the buffer.
For instance, it converts \"\\300\\255\" into \"\\255\" in
Emacs 23 (unicode)."
+ ;; FIXME: (default-value 'enable-multibyte-characters) is read-only
+ ;; so let-binding it is wrong. The right fix is to not use this
+ ;; macro at all any more, since it's been ill-defined from the start.
(let ((multibyte (make-symbol "multibyte"))
(buffer (make-symbol "buffer")))
`(if mm-emacs-mule
@@ -1593,8 +1596,8 @@
filename))
(mm-decompress-buffer filename nil t))))
(when decomp
- (set-buffer (letf (((default-value 'enable-multibyte-characters) nil))
- (generate-new-buffer " *temp*")))
+ (set-buffer (generate-new-buffer " *temp*"))
+ (mm-disable-multibyte)
(insert decomp)
(setq filename (file-name-sans-extension filename)))
(goto-char (point-min))
=== modified file 'lisp/gnus/yenc.el'
--- lisp/gnus/yenc.el 2010-01-13 08:35:10 +0000
+++ lisp/gnus/yenc.el 2010-04-23 14:59:23 +0000
@@ -89,8 +89,9 @@
(when (re-search-forward "^=yend.*$" end t)
(setq last (match-beginning 0))
(setq footer-alist (yenc-parse-line (match-string 0)))
- (letf (((default-value 'enable-multibyte-characters) nil))
- (setq work-buffer (generate-new-buffer " *yenc-work*")))
+ (with-current-buffer
+ (setq work-buffer (generate-new-buffer " *yenc-work*"))
+ (set-buffer-multibyte nil))
(while (< first last)
(setq char (char-after first))
(cond ((or (eq char ?\r)
prev parent reply other threads:[~2010-04-23 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 7:50 bug#6010: 24.0.50; setting-constant enable-multibyte-characters Katsumi Yamaoka
2010-04-23 16:16 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk4ryrwcv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).