From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6100: c-beginning-of-defun doesn't push mark Date: Wed, 05 May 2010 09:16:25 -0400 Message-ID: References: <87mxwf942y.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1273087131 26292 80.91.229.12 (5 May 2010 19:18:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 5 May 2010 19:18:51 +0000 (UTC) Cc: 6100@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 05 21:18:49 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O9k7L-0003Lw-Mw for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 May 2010 21:18:48 +0200 Original-Received: from localhost ([127.0.0.1]:39721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9k7J-0005v4-TC for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 May 2010 15:18:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9ec6-0003dm-MQ for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 09:26:10 -0400 Original-Received: from [140.186.70.92] (port=55768 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9ec5-0003be-8S for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 09:26:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9ec4-0002gL-Bj for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 09:26:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47003) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9ec2-0002fs-36; Wed, 05 May 2010 09:26:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O9eTG-0004gx-Gd; Wed, 05 May 2010 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Wed, 05 May 2010 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6100 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 6100-submit@debbugs.gnu.org id=B6100.127306539318022 (code B ref 6100); Wed, 05 May 2010 13:17:02 +0000 Original-Received: (at 6100) by debbugs.gnu.org; 5 May 2010 13:16:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9eSn-0004gd-7g for submit@debbugs.gnu.org; Wed, 05 May 2010 09:16:33 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9eSl-0004gW-U7 for 6100@debbugs.gnu.org; Wed, 05 May 2010 09:16:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAOsM4UvO+IB1/2dsb2JhbACdRHK+C4UTBIwu X-IronPort-AV: E=Sophos;i="4.52,333,1270440000"; d="scan'208";a="63446248" Original-Received: from 206-248-128-117.dsl.teksavvy.com (HELO alfajor.home) ([206.248.128.117]) by ironport2-out.pppoe.ca with ESMTP; 05 May 2010 09:16:26 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id C4051AF29E; Wed, 5 May 2010 09:16:25 -0400 (EDT) In-Reply-To: <87mxwf942y.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 04 May 2010 19:01:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 05 May 2010 09:17:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36700 Archived-At: > There is one annoying difference between `beginning-of-defun' > and `c-beginning-of-defun': > `beginning-of-defun' and `end-of-defun' pushes the mark for the > old point location to the mark ring with this code: > (or (not (eq this-command 'beginning-of-defun)) > (eq last-command 'beginning-of-defun) > (and transient-mark-mode mark-active) > (push-mark)) > but `c-beginning-of-defun' doesn't do that. > This patch add the same code to `c-beginning-of-defun' and `c-end-of-defun': Of course, I'd argue that the right fix is to use `beginning-of-defun'. Stefan