From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10062: 24.0.91; completions-first-difference Date: Mon, 16 Jan 2012 10:52:07 -0500 Message-ID: References: <8739do764s.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326729210 12042 80.91.229.12 (16 Jan 2012 15:53:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 16 Jan 2012 15:53:30 +0000 (UTC) Cc: 10062@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 16 16:53:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rmos9-0006xD-0q for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 16:53:25 +0100 Original-Received: from localhost ([::1]:45112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmos8-0007am-Fg for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 10:53:24 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:36469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmos1-0007aQ-8k for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 10:53:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rmorr-0001us-L9 for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 10:53:17 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmorr-0001ui-Jh for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 10:53:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Rmosj-0001p0-MS for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 10:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jan 2012 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10062-submit@debbugs.gnu.org id=B10062.13267291886938 (code B ref 10062); Mon, 16 Jan 2012 15:54:01 +0000 Original-Received: (at 10062) by debbugs.gnu.org; 16 Jan 2012 15:53:08 +0000 Original-Received: from localhost ([127.0.0.1]:60491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rmorr-0001nq-Rf for submit@debbugs.gnu.org; Mon, 16 Jan 2012 10:53:08 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:32794) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rmoro-0001ni-FN for 10062@debbugs.gnu.org; Mon, 16 Jan 2012 10:53:05 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EAFJHFE9FxKkV/2dsb2JhbABDqwmBJYEKgQaBcgEBBAFWIwULCzQSFBgNJIgNtW+JXQIBAQgCDBEDCQEBBgEFHgoEAQIBAQIDAwEBAQECgngBBgIDBwEEAQEBAYQNBIg7mmOEUg X-IronPort-AV: E=Sophos;i="4.71,518,1320642000"; d="scan'208";a="157001685" Original-Received: from 69-196-169-21.dsl.teksavvy.com (HELO ceviche.home) ([69.196.169.21]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Jan 2012 10:52:08 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1919E6610D; Mon, 16 Jan 2012 10:52:07 -0500 (EST) In-Reply-To: (Leo's message of "Mon, 16 Jan 2012 17:18:54 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55795 Archived-At: > I propose the attached patch following your advice i.e. strip faces when > used for completion. Could you take a look at it? Thanks. Rather than prevent faces from being added, I installed a patch which strips them before insertion. Stefan --- lisp/minibuffer.el 2012-01-05 09:46:05 +0000 +++ lisp/minibuffer.el 2012-01-16 15:41:07 +0000 @@ -571,6 +571,10 @@ (defun completion--replace (beg end newtext) "Replace the buffer text between BEG and END with NEWTEXT. Moves point to the end of the new text." + ;; The properties on `newtext' include things like + ;; completions-first-difference, which we don't want to include + ;; upon insertion. + (set-text-properties 0 (length newtext) nil newtext) ;; Maybe this should be in subr.el. ;; You'd think this is trivial to do, but details matter if you want ;; to keep markers "at the right place" and be robust in the face of