From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Mark Hepburn <mark.hepburn@gmail.com>
Cc: 12785@debbugs.gnu.org
Subject: bug#12785: [octave-mod] Changed behaviour of octave-mark-block?
Date: Tue, 04 Dec 2012 17:02:22 -0500 [thread overview]
Message-ID: <jwvk3sxscnl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAG1hmhhTxJnOnx4svVF8F7Jt=Z2yKhThZ2TfG5Xv0CXjW7hUgQ@mail.gmail.com> (Mark Hepburn's message of "Fri, 2 Nov 2012 18:42:28 +1100")
> for i=1:n, something; end;
> If octave-mark-block is invoked with the cursor anywhere inside the
> 'for' token, it will fail ("unbalanced parentheses"). The following
> situations all fail in the recent version, but succeed in the older
> version: |for, f|or, fo|r.
For the "|for" case I think the behavior makes sense (it will try to
mark the enclosing block). But maybe indeed it's an accidental change.
For the "f|or" and "fo|r" cases, indeed the smie primitives assume the
cursor is not within a token, so they get all confused. Shouldn't be
too hard to fix.
What should be the behavior when point is at "end|"? Should it mark
this block or the enclosing one?
Stefan
next prev parent reply other threads:[~2012-12-04 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 7:42 bug#12785: [octave-mod] Changed behaviour of octave-mark-block? Mark Hepburn
2012-12-04 22:02 ` Stefan Monnier [this message]
2012-12-04 23:23 ` Mark Hepburn
2012-12-05 5:30 ` Stefan Monnier
2012-12-05 12:04 ` Mark Hepburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk3sxscnl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12785@debbugs.gnu.org \
--cc=mark.hepburn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).