From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13419: make 'eabs' act more like a function Date: Sat, 12 Jan 2013 08:25:06 -0500 Message-ID: References: <50F10643.8000408@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1357997161 10280 80.91.229.3 (12 Jan 2013 13:26:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2013 13:26:01 +0000 (UTC) Cc: 13419@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 12 14:26:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tu16H-0008Ls-TR for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2013 14:26:18 +0100 Original-Received: from localhost ([::1]:35800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu161-0005QQ-TY for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2013 08:26:01 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu15w-0005QK-VL for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 08:26:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tu15t-0002Ft-H5 for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 08:25:56 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu15t-0002Fp-Dt for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 08:25:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tu164-0006Mt-Tj for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 08:26:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jan 2013 13:26:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13419 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13419-submit@debbugs.gnu.org id=B13419.135799713324426 (code B ref 13419); Sat, 12 Jan 2013 13:26:04 +0000 Original-Received: (at 13419) by debbugs.gnu.org; 12 Jan 2013 13:25:33 +0000 Original-Received: from localhost ([127.0.0.1]:56409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tu15X-0006Lu-TQ for submit@debbugs.gnu.org; Sat, 12 Jan 2013 08:25:33 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:17824) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tu15Q-0006Ld-Oh for 13419@debbugs.gnu.org; Sat, 12 Jan 2013 08:25:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkGAG6Zu09FpZpV/2dsb2JhbABEDoFtshaBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOIQppxgViCMFc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="212360118" Original-Received: from 69-165-154-85.dsl.teksavvy.com (HELO pastel.home) ([69.165.154.85]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Jan 2013 08:25:06 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 90F10592A5; Sat, 12 Jan 2013 08:25:06 -0500 (EST) In-Reply-To: <50F10643.8000408@cs.ucla.edu> (Paul Eggert's message of "Fri, 11 Jan 2013 22:44:19 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69652 Archived-At: > This patch doesn't fix any bugs, it's just a code cleanup. [...] > -/* We used to use `abs', but that clashes with system headers on some > - platforms, and using a name reserved by Standard C is a bad idea > - anyway. */ > -#if !defined (eabs) > -#define eabs(x) ((x) < 0 ? -(x) : (x)) > +/* Return the absolute value of X, without evaluating X more than once. > + X should be a signed integer, and X's absolute value should not > + exceed the maximum for its promoted type. > + > + If _Generic or typeof works, speed things up a bit by avoiding the > + conversion to intmax_t. The "~" promotes X's type, and checks that > + X is an integer. */ > +#if HAVE_C__GENERIC > +# define eabs(x) \ > + (_Generic (~ (x), int: abs, long: labs, long long: llabs, default: imaxabs) \ > + (x)) > +#elif HAVE_TYPEOF > +# define eabs(x) ({ typeof (~ (x)) eabsx = x; eabsx < 0 ? -eabsx : eabsx; }) > +#else > +# define eabs(x) imaxabs (x) > #endif Huh? Do you really consider this code cleaner? It's hideous and impenetrable. Not cool! Stefan