From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14387: 24.3; The return value of setf is not the last VAL in the list Date: Tue, 14 May 2013 22:01:00 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368583329 32470 80.91.229.3 (15 May 2013 02:02:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 May 2013 02:02:09 +0000 (UTC) Cc: 14387@debbugs.gnu.org To: =?UTF-8?Q?=E7=99=BD=E4=BA=95_?= =?UTF-8?Q?=E5=BD=B0?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 15 04:02:08 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UcR2d-0005hH-4D for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2013 04:02:07 +0200 Original-Received: from localhost ([::1]:39160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcR2c-0008FL-KR for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2013 22:02:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcR2Y-0008FC-UK for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 22:02:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcR2X-0003Vs-JS for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 22:02:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcR2X-0003Vo-G0 for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 22:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UcR2Z-0007PH-90 for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 22:02:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2013 02:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14387-submit@debbugs.gnu.org id=B14387.136858327228276 (code B ref 14387); Wed, 15 May 2013 02:02:03 +0000 Original-Received: (at 14387) by debbugs.gnu.org; 15 May 2013 02:01:12 +0000 Original-Received: from localhost ([127.0.0.1]:44922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcR1k-0007M1-20 for submit@debbugs.gnu.org; Tue, 14 May 2013 22:01:12 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:21061) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcR1h-0007LL-Er for 14387@debbugs.gnu.org; Tue, 14 May 2013 22:01:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rwb8/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJLEfkA6RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFG4rwb8/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJLEfkA6RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="12056496" Original-Received: from 184-175-6-252.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([184.175.6.252]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 14 May 2013 22:00:56 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C8428AE0C3; Tue, 14 May 2013 22:01:00 -0400 (EDT) In-Reply-To: ("=?UTF-8?Q?=E7=99=BD=E4=BA=95_?= =?UTF-8?Q?=E5=BD=B0?="'s message of "Sun, 12 May 2013 01:40:49 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74284 Archived-At: > (let ((pl '(aaa bbb))) (setf (cl-getf pl 'aaa) 'ccc)) > (aaa ccc) ; This should be ccc Oops, good point. The patch below should fix it (installed in trunk). Stefan === modified file 'lisp/emacs-lisp/cl-extra.el' --- lisp/emacs-lisp/cl-extra.el 2013-01-02 16:13:04 +0000 +++ lisp/emacs-lisp/cl-extra.el 2013-05-15 01:55:53 +0000 @@ -597,8 +597,11 @@ (macroexp-let2 nil d def (funcall do `(cl-getf ,getter ,k ,d) (lambda (v) - (funcall setter - `(cl--set-getf ,getter ,k ,v)))))))))) + (macroexp-let2 nil val v + `(progn + ,(funcall setter + `(cl--set-getf ,getter ,k ,val)) + ,val)))))))))) (setplist '--cl-getf-symbol-- plist) (or (get '--cl-getf-symbol-- tag) ;; Originally we called cl-get here,