From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14714: 24.3.50; `isearch-filter-predicate(s)' Date: Wed, 26 Jun 2013 21:32:01 -0400 Message-ID: References: <87vc50pmzw.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372296792 32257 80.91.229.3 (27 Jun 2013 01:33:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Jun 2013 01:33:12 +0000 (UTC) Cc: 14714@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 03:33:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Us15A-0004nW-3a for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 03:33:08 +0200 Original-Received: from localhost ([::1]:60921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Us159-0002Ch-Bn for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2013 21:33:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Us155-0002Cb-B2 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 21:33:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Us154-000344-JA for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 21:33:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Us154-000340-FW for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 21:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Us153-0002zT-Ub for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 21:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2013 01:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14714-submit@debbugs.gnu.org id=B14714.137229673011420 (code B ref 14714); Thu, 27 Jun 2013 01:33:01 +0000 Original-Received: (at 14714) by debbugs.gnu.org; 27 Jun 2013 01:32:10 +0000 Original-Received: from localhost ([127.0.0.1]:44070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us14E-0002y8-Eg for submit@debbugs.gnu.org; Wed, 26 Jun 2013 21:32:10 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:29022) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us14C-0002xv-89 for 14714@debbugs.gnu.org; Wed, 26 Jun 2013 21:32:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17262469" Original-Received: from 76-10-154-64.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Jun 2013 21:31:56 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 03FA8AE34D; Wed, 26 Jun 2013 21:32:01 -0400 (EDT) In-Reply-To: <87vc50pmzw.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 27 Jun 2013 00:31:13 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75625 Archived-At: >> Actually, shouldn't we revert this change and use >> (add-function :before-while ...) on isearch-filter-predicate instead? > Currently I'm exploring possibilities of using `:before-while' > instead of `run-hook-with-args-until-failure'. > IIUC, it can be used to replace hooks, so that for example, > when someone wants to put an additional function on `find-file', No, you're thinking of advice-add. add-function is different (tho it's used internally by advice-add). Basically, replace (add-hook 'isearch-filter-predicate #'foo nil t) with (add-function :before-while (local isearch-filter-predicate) #'foo) > (defvar isearch-filter-predicate nil) For add-function to work well, you want to change this default value to be a function, such as (lambda () t). Stefan