* bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.
@ 2013-12-14 14:18 Kenjiro NAKAYAMA
2013-12-21 20:45 ` Ted Zlatanov
2013-12-24 7:02 ` Lars Ingebrigtsen
0 siblings, 2 replies; 6+ messages in thread
From: Kenjiro NAKAYAMA @ 2013-12-14 14:18 UTC (permalink / raw)
To: 16144
I changed bookmark-browse's behavior. This problem gets more serious, if
many many windows are opend...
* Reproduce the problem.
Step1. Open two windows, one is *eww* and the other is not eww.
Step2. In the *eww*, open the bookmark list with "B" key. (Now one is *eww*, the other is *eww bookmarks*)
Step3. Select one URL in the bookmarklist(eww-bookmark-browse).
Step4. Now emacs window is only *eww*. <- #This is the problem.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-bookmark-browse): Don't hide windows with
browsing bookmark list.
---
lisp/net/eww.el | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..c4e948b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1179,10 +1179,8 @@ Differences in #targets are ignored."
(let ((bookmark (get-text-property (line-beginning-position) 'eww-bookmark)))
(unless bookmark
(error "No bookmark on the current line"))
- ;; We wish to leave this window, but if it's the only window here,
- ;; just let it remain.
- (ignore-errors
- (delete-window))
+ (eww-bookmark-quit)
+ (pop-to-buffer "*eww*")
(eww-browse-url (plist-get bookmark :url))))
(defun eww-next-bookmark ()
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.
2013-12-14 14:18 bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list Kenjiro NAKAYAMA
@ 2013-12-21 20:45 ` Ted Zlatanov
2013-12-24 7:02 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Ted Zlatanov @ 2013-12-21 20:45 UTC (permalink / raw)
To: Kenjiro NAKAYAMA; +Cc: 16144, Lars Magne Ingebrigtsen
On Sat, 14 Dec 2013 23:18:27 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote:
KN> I changed bookmark-browse's behavior. This problem gets more serious, if
KN> many many windows are opend...
KN> * Reproduce the problem.
KN> Step1. Open two windows, one is *eww* and the other is not eww.
KN> Step2. In the *eww*, open the bookmark list with "B" key. (Now one is *eww*, the other is *eww bookmarks*)
KN> Step3. Select one URL in the bookmarklist(eww-bookmark-browse).
KN> Step4. Now emacs window is only *eww*. <- #This is the problem.
I like the suggestion but am not sure if this should a defcustom. I
actually would like, when selecting a bookmark, to have the option to go
into a full-screen (single window) configuration for eww. Leaving for Lars.
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.
2013-12-14 14:18 bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list Kenjiro NAKAYAMA
2013-12-21 20:45 ` Ted Zlatanov
@ 2013-12-24 7:02 ` Lars Ingebrigtsen
2013-12-24 7:27 ` Lars Ingebrigtsen
1 sibling, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2013-12-24 7:02 UTC (permalink / raw)
To: Kenjiro NAKAYAMA; +Cc: 16144
Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:
> * net/eww.el (eww-bookmark-browse): Don't hide windows with
> browsing bookmark list.
This doesn't really help much. If you're starting with one window, the
patch will leave you with two windows, which isn't what you want. I
don't think it makes sense for the pop-up-a-new-buffer functions to
necessarily restore the original window layout after the buffer goes
away, anyway. It's not a "modal" extra buffer like hitting TAB when
doing file completion...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.
2013-12-24 7:02 ` Lars Ingebrigtsen
@ 2013-12-24 7:27 ` Lars Ingebrigtsen
2013-12-24 14:48 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2013-12-24 7:27 UTC (permalink / raw)
To: Kenjiro NAKAYAMA; +Cc: 16144
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I don't think it makes sense for the pop-up-a-new-buffer functions to
> necessarily restore the original window layout after the buffer goes
> away, anyway.
Or perhaps it should. I've now made it just save the window
configuration and restore it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.
2013-12-24 7:27 ` Lars Ingebrigtsen
@ 2013-12-24 14:48 ` Stefan Monnier
2013-12-24 18:08 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2013-12-24 14:48 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 16144, Kenjiro NAKAYAMA
>> I don't think it makes sense for the pop-up-a-new-buffer functions to
>> necessarily restore the original window layout after the buffer goes
>> away, anyway.
> Or perhaps it should. I've now made it just save the window
> configuration and restore it.
Don't. This is the wrong way to go about it.
Nowadays, quit-window tries to undo the effect of pop-to-buffer, so try
to get this to work instead. In the "quickly look at something case" it
should work just as well as saving/restoring the window config, but in
the more complex cases (e.g. pop to a new frame, or stick around for
a long time with lots of other window/buffer movements) it will
behave better.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-24 18:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 14:18 bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list Kenjiro NAKAYAMA
2013-12-21 20:45 ` Ted Zlatanov
2013-12-24 7:02 ` Lars Ingebrigtsen
2013-12-24 7:27 ` Lars Ingebrigtsen
2013-12-24 14:48 ` Stefan Monnier
2013-12-24 18:08 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).