From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16818: Acknowledgement (Undo in region after markers in undo history relocated) Date: Thu, 13 Mar 2014 09:24:28 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394717117 27949 80.91.229.3 (13 Mar 2014 13:25:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Mar 2014 13:25:17 +0000 (UTC) Cc: 16818@debbugs.gnu.org To: Barry OReilly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 13 14:25:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WO5dS-0004uJ-Kz for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 14:25:22 +0100 Original-Received: from localhost ([::1]:38902 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5dS-0007ou-3P for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 09:25:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5dI-0007et-Nh for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:25:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WO5dB-0006UT-5w for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:25:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5dB-0006UL-3X for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:25:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WO5d9-0004zd-Le for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:25:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Mar 2014 13:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16818 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16818-submit@debbugs.gnu.org id=B16818.139471707419130 (code B ref 16818); Thu, 13 Mar 2014 13:25:03 +0000 Original-Received: (at 16818) by debbugs.gnu.org; 13 Mar 2014 13:24:34 +0000 Original-Received: from localhost ([127.0.0.1]:35478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO5ce-0004yR-UR for submit@debbugs.gnu.org; Thu, 13 Mar 2014 09:24:33 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26902) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO5cb-0004yE-VE for 16818@debbugs.gnu.org; Thu, 13 Mar 2014 09:24:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="51706833" Original-Received: from 76-10-154-114.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Mar 2014 09:24:29 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ED2D76057F; Thu, 13 Mar 2014 09:24:28 -0400 (EDT) In-Reply-To: (Barry OReilly's message of "Wed, 12 Mar 2014 21:59:55 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86814 Archived-At: >> Thinking more about this, I think this is fixing the symptom, but >> not the cause. The cause is that primitive-undo shouldn't blindly >> obey a (MARKER . OFFSET) entry. Instead it should only obey it if >> the marker still points at the corresponding place. > From what I can tell, the root cause is relocating markers to > unrelated locations in the buffer while another part of Emacs still > has a reference to it. Not sure in which way what you're saying is different from what I'm saying. Are we in violent agreement? > Your counter proposal is a step from the root. For instance, the > markers within the mark rings will not adjust correctly, whilst with > my patch they will. Can you give an example incorrect adjustment? >> (creating new markers each time instead) > My patch actually results in fewer markers created. Right, I didn't mean that creating new markers is a problem. Stefan