From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17973: Thin space not thin at all Date: Sat, 19 Jul 2014 13:30:10 -0400 Message-ID: References: <87wqb9uyro.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1405791088 30477 80.91.229.3 (19 Jul 2014 17:31:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Jul 2014 17:31:28 +0000 (UTC) Cc: 17973@debbugs.gnu.org To: handa@gnu.org (K. Handa) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 19 19:31:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X8YTg-0002GJ-Oy for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jul 2014 19:31:20 +0200 Original-Received: from localhost ([::1]:55129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8YTg-00023a-Ay for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jul 2014 13:31:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8YTW-00022a-Re for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 13:31:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8YTP-0001qB-Bs for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 13:31:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8YTP-0001q0-9G for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 13:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X8YTO-0006zY-Fp for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 13:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jul 2014 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17973 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17973-submit@debbugs.gnu.org id=B17973.140579102026826 (code B ref 17973); Sat, 19 Jul 2014 17:31:02 +0000 Original-Received: (at 17973) by debbugs.gnu.org; 19 Jul 2014 17:30:20 +0000 Original-Received: from localhost ([127.0.0.1]:59632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8YSh-0006ya-Ai for submit@debbugs.gnu.org; Sat, 19 Jul 2014 13:30:20 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:60672) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8YSf-0006yN-9o for 17973@debbugs.gnu.org; Sat, 19 Jul 2014 13:30:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDYgoCNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDYgoCNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="78110820" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Jul 2014 13:30:10 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8831B60BEC; Sat, 19 Jul 2014 13:30:10 -0400 (EDT) In-Reply-To: <87wqb9uyro.fsf@gnu.org> (K. Handa's message of "Sun, 20 Jul 2014 00:57:47 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91669 Archived-At: >> > In addition to your patch, could you please try the following patch? > [...] >> Looks like this works, indeed! Yay! > I've just committed both changes to the trunk. But, in this part: > if (pixel_size * 2 < entity_size || entity_size * 2 < pixel_size) > /* This size is wrong by more than a factor 2: reject it! */ > return 0xFFFFFFFF; > the factor 2 is too arbitrary. Don't we need some > user-controllable variable here? It's indeed arbitrary. It might deserve a CPP macro, but I'd rather not add a configurable variable until there's a clear need for it. 2 seems to be large enough that it is hard to imagine a case where it will rule out a font that the user would want to use, yet it's small enough that it should solve the problem in the vast majority of cases where it matters. Stefan