From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20092: 24.4.91; False matches with incremental search in Info Date: Thu, 12 Mar 2015 15:16:30 -0400 Message-ID: References: <87egov3udi.fsf@moondust.localdomain> <87zj7ix55f.fsf@moondust.localdomain> <87bnjy9tn2.fsf@moondust.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426187849 26470 80.91.229.3 (12 Mar 2015 19:17:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Mar 2015 19:17:29 +0000 (UTC) Cc: 20092@debbugs.gnu.org To: nljlistbox2@gmail.com (N. Jackson) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 12 20:17:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YW8be-0003h2-NQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Mar 2015 20:17:18 +0100 Original-Received: from localhost ([::1]:33576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW8bd-0007IM-9k for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Mar 2015 15:17:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW8bU-0007An-Fa for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 15:17:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW8bO-0000v0-74 for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 15:17:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW8bO-0000uw-4p for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 15:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YW8bN-0001RP-Q7 for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 15:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Mar 2015 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20092-submit@debbugs.gnu.org id=B20092.14261877985496 (code B ref 20092); Thu, 12 Mar 2015 19:17:01 +0000 Original-Received: (at 20092) by debbugs.gnu.org; 12 Mar 2015 19:16:38 +0000 Original-Received: from localhost ([127.0.0.1]:44251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YW8az-0001QZ-V0 for submit@debbugs.gnu.org; Thu, 12 Mar 2015 15:16:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:24674) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YW8ay-0001QK-3u for 20092@debbugs.gnu.org; Thu, 12 Mar 2015 15:16:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ar4TAPOG1lRFxLnr/2dsb2JhbABbgwaDX4VTvhyCSQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLNBIUGA2IXAjOIwEBAQEGAgEfj3gHhCoFqXKBRSKECiKBMySBHAEBAQ X-IPAS-Result: Ar4TAPOG1lRFxLnr/2dsb2JhbABbgwaDX4VTvhyCSQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLNBIUGA2IXAjOIwEBAQEGAgEfj3gHhCoFqXKBRSKECiKBMySBHAEBAQ X-IronPort-AV: E=Sophos;i="5.09,536,1418101200"; d="scan'208";a="113402845" Original-Received: from 69-196-185-235.dsl.teksavvy.com (HELO pastel.home) ([69.196.185.235]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Mar 2015 15:16:30 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2C5CF6E4; Thu, 12 Mar 2015 15:16:30 -0400 (EDT) In-Reply-To: <87bnjy9tn2.fsf@moondust.localdomain> (N. Jackson's message of "Thu, 12 Mar 2015 11:29:05 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100416 Archived-At: > confusing behaviour that prompted me to report this bug.); and 3) if the > value of search-invisible is `open' then the chunk of invisible text is > made visible ("opened") temporarilly, and the match shown within it. That's right. But currently `open' doesn't actually work for text that's hidden via text-properties (as opposed to overlays). I think that's the problem you bumped into. I'm not sure what's the best and/or simplest way to fix it. Maybe a first step would be to emit a message explaining that the match is inside hidden text (at least so the user gets a clue about what's going on). > It seems odd to have a function (isearch-toggle-invisible) to "toggle" > the state of a variable that can have three states; cycling seems more > appropriate. Agreed, tho the current implementation indeed toggles. > In any case looking at the code, it does actually toggle > (between nil and t), but also changes `open' to nil, and then one can > never "toggle" back to `open'. That's indeed another problem that should be fixed. Stefan