bug#11822: 24.1; emacsclient terminal mode captures escape characters as text

[Stefan Monnier <monnier@iro.umontreal.ca>]

> (Also: Iconifying the remote frame doesn't seem to help. In
> prepare_menu_bars, when all_windows is set but some_windows is not, the
> call to x_consider_frame_title, which can trigger face realization, *is*
> called for iconified frames.)

Maybe instead of doing

  prepare_menu_bars:
    (forall frames (compute-title-and-stuff))
  later:
    (forall frames (recompute-glyph-matrices-and-then-display))

we should do

  (forall frames
    (compute-title-and-stuff)
    (recompute-glyph-matrices-and-then-display))

>  * Some requests do require replies from the server, like color lookup
>    (return RGB data from server-side database) or color cell allocation
>    (return pixel ID), and the library is not generally designed to allow
>    for pipelining of these requests; it'll wait for the reply before
>    returning control to the application.

BTW, IIUC while Xlib is not designed for that, the newer Xcb library
exposes the underlying wire protocol more directly, making it possible
to send several color requests before waiting for the replies.

>  * Some types of displays are limited in the number of colors they can
>    show, so being a good X neighbor involves freeing colors (the correct
>    number of times) if you're done with them and not about to shut down
>    the connection, unless you're using a private colormap, in which case
>    the only foot you might shoot is your own. I'm not sure if these
>    display types are at all common any more.

FWIW, I've used 8bit-deep framebuffers not that long ago.
But they're probably rare by now, indeed.

> For a local X server, the round trip time is cheap enough that it's
> probably good enough to generate all the extra traffic and accept the
> (very brief) waits for replies, and just let the X server deal with
> maintaining the reference counts on color cells.

As mentioned earlier, I think this is not true if we repeat it per-frame
since we can have 100 frames, at which point the delay can become
significant even locally.


        Stefan