From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#22983: [ Patch ] Re: bug#22983: syntax-ppss returns wrong result. Date: Mon, 11 Sep 2017 16:20:02 -0400 Message-ID: References: <83h8wlz1kf.fsf@gnu.org> <20170902174027.GB4267@ACM> <20170907204502.GC4488@ACM> <69e034d3-7a52-cc81-dc56-e5308ad5dce0@yandex.ru> <20170910113626.GB3588@ACM> <20170911194238.GB3605@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505161290 31543 195.159.176.226 (11 Sep 2017 20:21:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Sep 2017 20:21:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: John Wiegley , Philipp Stephani , Dmitry Gutov , 22983@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 11 22:21:24 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drVCb-00072D-8u for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 22:21:05 +0200 Original-Received: from localhost ([::1]:60384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drVCi-0004Li-Gc for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 16:21:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drVCb-0004LN-2i for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 16:21:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drVCX-0007N4-Ss for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 16:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53668) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drVCX-0007My-Q4 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 16:21:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drVCX-0004ve-Kq for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 16:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2017 20:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22983-submit@debbugs.gnu.org id=B22983.150516120518856 (code B ref 22983); Mon, 11 Sep 2017 20:21:01 +0000 Original-Received: (at 22983) by debbugs.gnu.org; 11 Sep 2017 20:20:05 +0000 Original-Received: from localhost ([127.0.0.1]:34115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drVBd-0004u4-1f for submit@debbugs.gnu.org; Mon, 11 Sep 2017 16:20:05 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:58449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drVBb-0004tw-Fb for 22983@debbugs.gnu.org; Mon, 11 Sep 2017 16:20:04 -0400 Original-Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v8BKK2Ag004690; Mon, 11 Sep 2017 16:20:02 -0400 Original-Received: by lechazo.home (Postfix, from userid 20848) id 7A8E060136; Mon, 11 Sep 2017 16:20:02 -0400 (EDT) In-Reply-To: <20170911194238.GB3605@ACM> (Alan Mackenzie's message of "Mon, 11 Sep 2017 19:42:38 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6113=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6113> : inlines <6063> : streams <1762593> : uri <2498798> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136808 Archived-At: > difficult, I agree, but do we need it? How often are there going to be > nested or alternating narrowing with enough calls to syntax-ppss to > cause the establishment of syntax-ppss-cache (as opposed to merely > syntax-ppss-last, which my patch doesn't consider sufficient reason to > store a new narrow-cache)? (These aren't rhetorical questions, by the > way, but real ones. Which is the best way forward?) I agree that it probably doesn't make much difference in practice. > I couldn't agree more. However, syntax-ppss is established and there > are callers that depend on its literal specification. Maybe a way > forward would be to introduce a new function equivalent to > (parse-partial-sexp 1 x) and deprecate syntax-ppss. However, a name > would need to be found for this new function, not an easy task. ;-) > (syntax-ppss is a very good name, but couldn't be reused.) Let's go with your patch for now, and then see if Dmitry's impression that adding a call to `widen` before the call works even better. Stefan