From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#29767: 26.0.90; Failing auto-fill in message-mode because of bad state (comment-skip-end) Date: Wed, 03 Jan 2018 23:59:39 -0500 Message-ID: References: <87ind3zqf2.fsf@imladris> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515041897 1086 195.159.176.226 (4 Jan 2018 04:58:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 4 Jan 2018 04:58:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29767@debbugs.gnu.org To: "Jose A. Ortega Ruiz" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 04 05:58:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWxbW-0008BH-5X for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Jan 2018 05:58:10 +0100 Original-Received: from localhost ([::1]:47297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWxdT-0003gO-Nl for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Jan 2018 00:00:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWxdO-0003gI-U4 for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 00:00:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWxdL-0000x4-PF for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 00:00:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54504) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWxdL-0000wx-Mk for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 00:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWxdL-0006vN-55 for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 00:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2018 05:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29767-submit@debbugs.gnu.org id=B29767.151504198826553 (code B ref 29767); Thu, 04 Jan 2018 05:00:03 +0000 Original-Received: (at 29767) by debbugs.gnu.org; 4 Jan 2018 04:59:48 +0000 Original-Received: from localhost ([127.0.0.1]:34952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWxd5-0006uD-W4 for submit@debbugs.gnu.org; Wed, 03 Jan 2018 23:59:48 -0500 Original-Received: from pmta11.teksavvy.com ([76.10.157.34]:27147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWxd3-0006tu-Te for 29767@debbugs.gnu.org; Wed, 03 Jan 2018 23:59:46 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2FFCgDws01a/xCds2tdHgEGDIM+gVqPUI4TAYIAMwGZCwqFNQQCAoQvRBQBAQEBAQEBAQEDaCiFJQEEAVYjBQsLNBIUGA0kijkItGiKPgEBAQEGAgElhBOIf4saBZM1kB6hQYd2lwmBPDYjgU8yGggwgmeDCIFsI4k3AQEB X-IPAS-Result: A2FFCgDws01a/xCds2tdHgEGDIM+gVqPUI4TAYIAMwGZCwqFNQQCAoQvRBQBAQEBAQEBAQEDaCiFJQEEAVYjBQsLNBIUGA0kijkItGiKPgEBAQEGAgElhBOIf4saBZM1kB6hQYd2lwmBPDYjgU8yGggwgmeDCIFsI4k3AQEB X-IronPort-AV: E=Sophos;i="5.45,505,1508817600"; d="scan'208";a="17317974" Original-Received: from 107-179-157-16.cpe.teksavvy.com (HELO ceviche.home) ([107.179.157.16]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 23:59:40 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 96A6966326; Wed, 3 Jan 2018 23:59:39 -0500 (EST) In-Reply-To: <87ind3zqf2.fsf@imladris> (Jose A. Ortega Ruiz's message of "Mon, 18 Dec 2017 22:17:53 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141766 Archived-At: > Unfortunately, i cannot reproduce the bug reliably, but these are the > symptoms: I think I found the culprit: syntax-propertize relies incorrectly on syntax-ppss to add syntax-ppss-flush-cache to before-change-functions. This works fine as long as syntax-ppss is called, but in message-mode buffers, syntax-propertize is always called but not syntax-ppss (it may get called depending on the operations you perform, but it's not called initially, e.g. because font-lock is told not to use the syntax-table to highlight strings and comments). The patch below seems to fix it for me. Is it OK to push it to emacs-26? Stefan diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el index a1b70b1869..a0493cc1ba 100644 --- a/lisp/emacs-lisp/syntax.el +++ b/lisp/emacs-lisp/syntax.el @@ -291,6 +291,9 @@ syntax-propertize ;; (message "Needs to syntax-propertize from %s to %s" ;; syntax-propertize--done pos) (set (make-local-variable 'parse-sexp-lookup-properties) t) + (when (< syntax-propertize--done (point-min)) + (add-hook 'before-change-functions + #'syntax-ppss-flush-cache t t)) (save-excursion (with-silent-modifications (make-local-variable 'syntax-propertize--done) ;Just in case!