From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17127: `call-process' circumvents password concealment w/ `read-passwd' Date: Wed, 23 Oct 2019 18:01:45 -0400 Message-ID: References: <871txntb60.fsf@nbtrap.com> <87y2y7gogl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="56451"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Nathan Trapuzzano , 17127@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 24 00:04:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNOjo-000EWA-7H for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Oct 2019 00:04:16 +0200 Original-Received: from localhost ([::1]:49686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNOjl-00057c-P0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 18:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51715) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNOie-0004uU-1y for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 18:03:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNOic-0005Ia-HL for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 18:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNOic-0005ID-CU for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 18:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNOic-00089p-6e for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 18:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 22:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 17127-submit@debbugs.gnu.org id=B17127.157186812231268 (code B ref 17127); Wed, 23 Oct 2019 22:03:02 +0000 Original-Received: (at 17127) by debbugs.gnu.org; 23 Oct 2019 22:02:02 +0000 Original-Received: from localhost ([127.0.0.1]:35113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNOhd-000888-TB for submit@debbugs.gnu.org; Wed, 23 Oct 2019 18:02:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNOhc-00087l-Fe for 17127@debbugs.gnu.org; Wed, 23 Oct 2019 18:02:00 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 44DB981155; Wed, 23 Oct 2019 18:01:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B15BF8004C; Wed, 23 Oct 2019 18:01:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1571868112; bh=VH6N/3SpfxH6rIbsSad2oISaeVrawx6JT0GSgdYv1mI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=P6XwE6C9IDI5sRs9+WcOa2pGA8pFB4Ufig/DCyWZHmfGA6/n022Ju+xOumUD7oU2o 4HFFp9LyIuRSvsN5VQ9JOpjHwDBLvCjVV6zMrNGeiwGSsbN1oZbTOb16CcL7JQFT+k spPnBo7l0RH4p9h8eGMlCtGJ8bbfQ9rRZ4iGk6jUFRsm9IHE9/dKKxy3DGgdGFOCqY M8AenILmDcKOiRW4LqNDYz3U+jwlZF4DY38HMyjtqXEYiJxm+RsnRcftxdomld7WnE 28QG0aGFa1BnHDpBcLOv5ZbNi/ZecdeKcUg2sybAbTbdfrfQd0JSyE0ghPRvSvMddY n2TfR44lxU4xA== Original-Received: from pastel (unknown [216.154.30.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7B6901209CA; Wed, 23 Oct 2019 18:01:52 -0400 (EDT) In-Reply-To: <87y2y7gogl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Sep 2019 16:35:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170100 Archived-At: > The following patch fixes this, I think, by using post-command-hook > instead of after-change-functions. Actually, in theory after-change-functions should catch all cases whereas post-command-hook might miss some (i.e. chars inserted not while running a command, e.g. from a process filter). So while your new code probably works fine in practice (and is a good workaround for now) , I think the original code is "more correct" and we should try and figure out why it didn't work: how come after-change-functions is not run (or not correctly) by call-process? Stefan