From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Date: Tue, 31 Mar 2020 11:13:27 -0400 Message-ID: References: <87k131myzf.fsf@gmail.com> <83lfng1tb4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="76195"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: casouri@gmail.com, stepnem@gmail.com, 40332@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 31 17:14:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJIaq-000JiA-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Mar 2020 17:14:20 +0200 Original-Received: from localhost ([::1]:39964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJIap-0001XP-O0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Mar 2020 11:14:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59327) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJIaZ-0001SS-K1 for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 11:14:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJIaY-0002v1-N8 for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 11:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJIaY-0002ut-K0 for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 11:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJIaY-00074l-Fn for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 11:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Mar 2020 15:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40332 X-GNU-PR-Package: emacs Original-Received: via spool by 40332-submit@debbugs.gnu.org id=B40332.158566762227130 (code B ref 40332); Tue, 31 Mar 2020 15:14:02 +0000 Original-Received: (at 40332) by debbugs.gnu.org; 31 Mar 2020 15:13:42 +0000 Original-Received: from localhost ([127.0.0.1]:36806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJIaE-00073W-Gf for submit@debbugs.gnu.org; Tue, 31 Mar 2020 11:13:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJIaC-00073E-D9 for 40332@debbugs.gnu.org; Tue, 31 Mar 2020 11:13:40 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2B67F81234; Tue, 31 Mar 2020 11:13:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B881181367; Tue, 31 Mar 2020 11:13:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1585667609; bh=ELoehrrPTXSA3yjRTvzxZgdGQLtoV82SdfMa6P5isGU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QENJ94wg4Hr8juORk3Wf3rJr7NGStOws9g2vNyqpWjdJ77G4SxzMdaZzc3uC8OUHR zG1EjzqlJgzboWHpQzBIjJjD6cCce4CkYSLulvmOrZ2sIoFmJGvFx2X2+JKOsN+F9g Xayz8pZly6lmpIZggou012RSqT8xr4IPkKbhqIPhh2RtR6FEladh4BT3ZX61pG4DhT 0VP+CE8wqxjKOTtBmzeNZsRLEbwEKzSFbeH23YTlVNCC/ALqL6/sMy/2+w1NQpRFBE XgAvPksKHFfdCqGjNm241TSks+EjKNC2XArCswwfzjkKgGFiC+5xUaz3FRn0Bt3hhL qc+M7wWTlKIlg== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7C7D71202AC; Tue, 31 Mar 2020 11:13:29 -0400 (EDT) In-Reply-To: <83lfng1tb4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Mar 2020 17:40:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177915 Archived-At: >> + ;; We used to bind `inhibit-modification-hooks' to try and speed up >> + ;; execution, in particular, to prevent the font-lock hook from running >> + ;; until the directory is all read in. >> + ;; I strongly suspect that this was only useful in Emacs<21, because >> + ;; jit-lock made it a non-issue. >> + ;; Nevertheless, I used `combine-change-calls' which provides the >> + ;; same performance advantages, just in case. > > FWIW, according to "git log", the change which introduced > inhibit-modification-hooks was made by RMS in Dec 2008, so it's > unlikely that had anything to do with Emacs before v21. Maybe we > should augment that part of the comment? Sounds right, yes, Stefan