* bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
@ 2020-03-30 19:20 Štěpán Němec
2020-03-30 19:47 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Štěpán Němec @ 2020-03-30 19:20 UTC (permalink / raw)
To: 40332
`dired-readin' binds `inhibit-modification-hooks' to t, so the buffer
changes caused by populating dired buffers are not noticeable in
`after-change-functions'.
A practical example of the problem:
https://gitlab.com/stepnem/stripes-el/-/issues/1#note_309176403
Related discussion:
https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00921.html
In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.14, cairo version 1.17.3)
of 2020-03-28 built on lenora
Repository revision: e27b8882e3969412876561af8fd30144820ec81a
Repository branch: master
--
Štěpán
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
2020-03-30 19:20 bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Štěpán Němec
@ 2020-03-30 19:47 ` Stefan Monnier
2020-03-30 20:03 ` Štěpán Němec
2020-03-31 14:40 ` Eli Zaretskii
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2020-03-30 19:47 UTC (permalink / raw)
To: Štěpán Němec; +Cc: 40332-done, Yuan Fu
Version: 28.1
> `dired-readin' binds `inhibit-modification-hooks' to t, so the buffer
> changes caused by populating dired buffers are not noticeable in
> `after-change-functions'.
Indeed, thanks. I just installed into `master` the patch below which
should fix this problem.
Can you confirm it works for you?
Stefan
diff --git a/lisp/dired.el b/lisp/dired.el
index b66bb03471..d58c37be2f 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -1208,15 +1208,11 @@ dired-readin
;; default-directory and dired-actual-switches must be buffer-local
;; and initialized by now.
- (let (dirname
- ;; This makes read-in much faster.
- ;; In particular, it prevents the font lock hook from running
- ;; until the directory is all read in.
- (inhibit-modification-hooks t))
- (if (consp dired-directory)
- (setq dirname (car dired-directory))
- (setq dirname dired-directory))
- (setq dirname (expand-file-name dirname))
+ (let ((dirname
+ (expand-file-name
+ (if (consp dired-directory)
+ (car dired-directory)
+ dired-directory))))
(save-excursion
;; This hook which may want to modify dired-actual-switches
;; based on dired-directory, e.g. with ange-ftp to a SysV host
@@ -1226,17 +1222,25 @@ dired-readin
(setq buffer-undo-list nil))
(setq-local file-name-coding-system
(or coding-system-for-read file-name-coding-system))
- (let ((inhibit-read-only t)
- ;; Don't make undo entries for readin.
- (buffer-undo-list t))
- (widen)
- (erase-buffer)
- (dired-readin-insert))
- (goto-char (point-min))
- ;; Must first make alist buffer local and set it to nil because
- ;; dired-build-subdir-alist will call dired-clear-alist first
- (setq-local dired-subdir-alist nil)
- (dired-build-subdir-alist)
+ (widen)
+ ;; We used to bind `inhibit-modification-hooks' to try and speed up
+ ;; execution, in particular, to prevent the font-lock hook from running
+ ;; until the directory is all read in.
+ ;; I strongly suspect that this was only useful in Emacs<21, because
+ ;; jit-lock made it a non-issue.
+ ;; Nevertheless, I used `combine-change-calls' which provides the
+ ;; same performance advantages, just in case.
+ (combine-change-calls (point-min) (point-max)
+ (let ((inhibit-read-only t)
+ ;; Don't make undo entries for readin.
+ (buffer-undo-list t))
+ (erase-buffer)
+ (dired-readin-insert))
+ (goto-char (point-min))
+ ;; Must first make alist buffer local and set it to nil because
+ ;; dired-build-subdir-alist will call dired-clear-alist first
+ (setq-local dired-subdir-alist nil)
+ (dired-build-subdir-alist))
(let ((attributes (file-attributes dirname)))
(if (eq (car attributes) t)
(set-visited-file-modtime (file-attribute-modification-time
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
2020-03-30 19:47 ` Stefan Monnier
@ 2020-03-30 20:03 ` Štěpán Němec
2020-03-31 14:40 ` Eli Zaretskii
1 sibling, 0 replies; 5+ messages in thread
From: Štěpán Němec @ 2020-03-30 20:03 UTC (permalink / raw)
To: monnier; +Cc: Yuan Fu, 40332
On Mon, 30 Mar 2020 15:47:17 -0400
Stefan Monnier wrote:
> I just installed into `master` the patch below which should fix this
> problem.
>
> Can you confirm it works for you?
Confirmed, thank you!
--
Štěpán
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
2020-03-30 19:47 ` Stefan Monnier
2020-03-30 20:03 ` Štěpán Němec
@ 2020-03-31 14:40 ` Eli Zaretskii
2020-03-31 15:13 ` Stefan Monnier
1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2020-03-31 14:40 UTC (permalink / raw)
To: Stefan Monnier; +Cc: casouri, stepnem, 40332
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 30 Mar 2020 15:47:17 -0400
> Cc: 40332-done@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
>
> + ;; We used to bind `inhibit-modification-hooks' to try and speed up
> + ;; execution, in particular, to prevent the font-lock hook from running
> + ;; until the directory is all read in.
> + ;; I strongly suspect that this was only useful in Emacs<21, because
> + ;; jit-lock made it a non-issue.
> + ;; Nevertheless, I used `combine-change-calls' which provides the
> + ;; same performance advantages, just in case.
FWIW, according to "git log", the change which introduced
inhibit-modification-hooks was made by RMS in Dec 2008, so it's
unlikely that had anything to do with Emacs before v21. Maybe we
should augment that part of the comment?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
2020-03-31 14:40 ` Eli Zaretskii
@ 2020-03-31 15:13 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2020-03-31 15:13 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: casouri, stepnem, 40332
>> + ;; We used to bind `inhibit-modification-hooks' to try and speed up
>> + ;; execution, in particular, to prevent the font-lock hook from running
>> + ;; until the directory is all read in.
>> + ;; I strongly suspect that this was only useful in Emacs<21, because
>> + ;; jit-lock made it a non-issue.
>> + ;; Nevertheless, I used `combine-change-calls' which provides the
>> + ;; same performance advantages, just in case.
>
> FWIW, according to "git log", the change which introduced
> inhibit-modification-hooks was made by RMS in Dec 2008, so it's
> unlikely that had anything to do with Emacs before v21. Maybe we
> should augment that part of the comment?
Sounds right, yes,
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-31 15:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-30 19:20 bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Štěpán Němec
2020-03-30 19:47 ` Stefan Monnier
2020-03-30 20:03 ` Štěpán Němec
2020-03-31 14:40 ` Eli Zaretskii
2020-03-31 15:13 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).