From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#42149: Substring and flex completion ignore implicit trailing =?UTF-8?Q?=E2=80=98any=E2=80=99?= Date: Mon, 28 Dec 2020 11:03:54 -0500 Message-ID: References: <874kk7107v.fsf@gmail.com> <875z4ml1l2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5610"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42149@debbugs.gnu.org, Dario Gjorgjevski To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 28 17:05:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktv1D-0001MY-62 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Dec 2020 17:05:11 +0100 Original-Received: from localhost ([::1]:33104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktv1C-0001dg-6U for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Dec 2020 11:05:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktv14-0001cw-Sa for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 11:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktv14-0003yz-LM for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 11:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktv14-00037c-Fb for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 11:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2020 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42149-submit@debbugs.gnu.org id=B42149.160917145111909 (code B ref 42149); Mon, 28 Dec 2020 16:05:02 +0000 Original-Received: (at 42149) by debbugs.gnu.org; 28 Dec 2020 16:04:11 +0000 Original-Received: from localhost ([127.0.0.1]:36565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktv0F-000361-8D for submit@debbugs.gnu.org; Mon, 28 Dec 2020 11:04:11 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktv0A-00035M-3n for 42149@debbugs.gnu.org; Mon, 28 Dec 2020 11:04:09 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 932C6809C6; Mon, 28 Dec 2020 11:04:00 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5D8268065D; Mon, 28 Dec 2020 11:03:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1609171435; bh=1xEsy9Jep5GBBT3a5agjZI/JLDhD248ifEjWiLzGfi4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RlizyjIB3ryRromllpUwjhXIKiVG3SpTKxN2eCHsitiKrJrvZ2YywUxmWSrBOUMhN A1/ezOjVazgQyrw/VMziz3WQn1Pt2Cm4v145jve9kyeXTQp5XPAVR+f+e76WugK0WD z3R5ulLmo0AkBgWCGKqns2iO6uXe4XgjQBQugpCJDzdmjJw5HOxz5dpCW8CnCFy42M mq5YLqs/UcNHJrwtUS+m9RHxXYjHfW7OENOsa4eFHGGx30+nMvvBi/fJlhBVqK565k tV5c5x1a9iNag15F6PtEr0m8F+fITrKy8ND//qArQ8322PchUxH2P1vW737Dl81vRs B/vOtkg6I7x5w== Original-Received: from alfajor (unknown [104.247.243.191]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 145A912034B; Mon, 28 Dec 2020 11:03:55 -0500 (EST) In-Reply-To: <875z4ml1l2.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 28 Dec 2020 09:30:33 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196870 Archived-At: > This is one of them. > > (ert-deftest completion-pcm-test-3 () > ;; Full match! > (should (eql > (completion--pcm-score > (car (completion-pcm-all-completions > "R" '("R" "hello") nil 1))) > 1.0))) BTW, a good improvement to the tests would be to replace the score equality tests with score ordering comparisons (like "score of foo > score of bar") since it'd be perfectly OK to use a different scoring system which gives different values as long as the relative ordering is still obeyed. Stefan