From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#41423: Installing the fix for bug#41423 on emacs-27 (was: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest]) Date: Sun, 31 Jan 2021 23:36:09 -0500 Message-ID: References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34315"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: =?UTF-8?Q?andr=C3=A9s_?= =?UTF-8?Q?ram=C3=ADrez?= , 41423@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 01 05:37:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6Qxf-0008oy-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Feb 2021 05:37:16 +0100 Original-Received: from localhost ([::1]:48382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6Qxe-0006VL-7t for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Jan 2021 23:37:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6QxT-0006VC-H6 for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 23:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6QxR-0000c9-Pu for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 23:37:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6QxR-0002Cf-Lf for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 23:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Feb 2021 04:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41423 X-GNU-PR-Package: emacs Original-Received: via spool by 41423-submit@debbugs.gnu.org id=B41423.16121541818419 (code B ref 41423); Mon, 01 Feb 2021 04:37:01 +0000 Original-Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 04:36:21 +0000 Original-Received: from localhost ([127.0.0.1]:58462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6Qwm-0002Bi-GP for submit@debbugs.gnu.org; Sun, 31 Jan 2021 23:36:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6Qwj-0002BT-5Y for 41423@debbugs.gnu.org; Sun, 31 Jan 2021 23:36:19 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D2D33808A9; Sun, 31 Jan 2021 23:36:11 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6385D8079B; Sun, 31 Jan 2021 23:36:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612154170; bh=tvb7M4/LWGTfEIMt/c8pB6Cgp+rWeHzrz2Dwovwifcg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lEGxpdL5pGS/Zrv6EfUp8vg2KjWhXqeGsqnkXdqdPQDqNlAB4VUJBdB/YQ/edqJlV JxLvWcJHYWpEuKi0/QnbWDiRISUaNEC8uvyqRO9TBK+SamdZg3K0ph9tPR4yxflANT lcmR/h0tDyAYvqj/G9Pegm6EbyesDWESUXH608fG8xnEHrlZu6SSgtVrSiJMNXqNVW z5iGdVvwrChOh7ArRGHMlwDlJ05/lxqndk9XHzsP1pxzA7BIbMZCcCkcXCq7tR00tl 6cppIdpQRC/OrK8OC5ORzJHbY40R8cJsEJOlw2LGrcbFO6gki9ZmkcCzy+ih3t8tC2 dHWbSGQ4fEbzg== Original-Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2B954120147; Sun, 31 Jan 2021 23:36:10 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Sun, 31 Jan 2021 21:45:39 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199049 Archived-At: Stefan Monnier [2021-01-31 21:45:39] wrote: > FWIW, I installed a variant of my earlier patch into `master`. > I suspect it has a few rough edges, so watch out for regressions, please > and complain to me (with as precise a recipe as you can) when you bump > into them, I installed a further change which should fix the main issue I could foresee. I'm now reasonably happy with the patch (I think it's "right" rather than a quick ad-hoc fix. It deserves further improvements to add some form of caching, but that's largely orthogonal to this bug report). IIUC Michael had marked this bug as "blocking" for Emacs-27, so this argues for installing it on the `emacs-27` branch. The patch is not without risks seeing how it changes a function from returning a list to returning a function and how it fundamentally changes *when* the code is executed. So I'm not sure whether it should go on the `emacs-27` branch: A- For non-Eshell users it is "obviously safe". B- For Eshell-over-Tramp users it should be a clear improvement even if it turns out to introduce some unforeseen regressions in some cases. C- Finally, Eshell-not-over-Tramp users should hopefully see no difference at all, which mostly means no improvement to make up for any risk of regression. So, is the improvement in B worth the risk in C? Stefan