From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#9923: 24.0.91; `where-is' does not find recentf menu items (cmds, not files) Date: Wed, 25 Aug 2021 10:49:09 -0400 Message-ID: References: <76FA3F83D086455EAA01FF0FB000FCDB@us.oracle.com> <871r6hk99k.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13273"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 9923@debbugs.gnu.org, Drew Adams To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 16:50:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIuEC-00039b-RO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 16:50:09 +0200 Original-Received: from localhost ([::1]:42936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIuEB-00050T-Gd for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 10:50:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIuE6-0004z3-72 for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 10:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIuE5-0005j1-W0 for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 10:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIuE5-00063v-UY for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 10:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9923-submit@debbugs.gnu.org id=B9923.162990295923248 (code B ref 9923); Wed, 25 Aug 2021 14:50:01 +0000 Original-Received: (at 9923) by debbugs.gnu.org; 25 Aug 2021 14:49:19 +0000 Original-Received: from localhost ([127.0.0.1]:47302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIuDP-00062u-CC for submit@debbugs.gnu.org; Wed, 25 Aug 2021 10:49:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIuDN-00062h-Jb for 9923@debbugs.gnu.org; Wed, 25 Aug 2021 10:49:18 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C63C18078F; Wed, 25 Aug 2021 10:49:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4A56B8065C; Wed, 25 Aug 2021 10:49:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1629902950; bh=A8ZcONJh7fpsIlOeQmYbrcziUU0gl96pAipU7QtRuOA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RzC0N1KeVavmdNQ+putlg1oWALNrAQ/03wglHSjPTz/N6vl9JFsjGGsw2x86NdLSb p1BCMBfLJm0bxVtsOu96m1knQX6RAZqY/Yww4yGXaP4eDx9vsvnW0QwDT5S1aBbWft gvn9oJDk7CqZi5hk0LfQ0c1BybYlji2EBwWz9NFuIdELTLUDqQKTyxhCYJzMFPOZxb QiWt6EON0bbcPgcuRkxPo+Au780pRivYjxFhYX1zhD1+XfKA8jbeD0hyY4PUkPGaeJ ccveskrQIgv/kBst1qMg3XC0jq7yd0ITEKGwztH0Uotc4QBDQTCQZrgdjTvKkEXztl QkutmL2SMgR9A== Original-Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1D65D120223; Wed, 25 Aug 2021 10:49:10 -0400 (EDT) In-Reply-To: <871r6hk99k.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 25 Aug 2021 14:18:31 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212641 Archived-At: Lars Ingebrigtsen [2021-08-25 14:18:31] wrote: > Stefan Monnier writes: >>> The bug is not about the file-name entries in the `Open Recent' menu, >>> but the menu items that represent commands should show up as bindings >>> for `C-h w', no? If not, why not? >> >> Indeed, where-is won't find bindings in menus defined with easy-menu and >> using the :filter thingy. Hmm... > > This problem is still present in Emacs 28. I tried briefly following > the logic in where_is_internal and friends, but... > > I guess we'd have to check for :filter here, evaluate the filter > function, and then look up the command in the resulting ... menu > entries? Uhm. Indeed, and evaluating the :filter may not necessarily return the "right" result (when that result depends on specific conditions of the time or context when it is run). So IIRC `where-is` instead uses the "unfiltered" binding. So you can often get what you want by being careful about the BINDING you put into `(menu-item "foo" BINDING :filter ...). Stefan