From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54034: 29.0.50; Diff prettify broken for empty files Date: Sun, 20 Feb 2022 09:40:52 -0500 Message-ID: References: <87iltex7bo.fsf@gmail.com> <87v8xakm0i.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18943"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54034@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 20 15:42:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLnQ3-0004mY-Nk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 15:42:35 +0100 Original-Received: from localhost ([::1]:43550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLnQ2-0005jf-Ko for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 09:42:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLnPX-0005EB-9o for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 09:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLnPW-0006Tv-3H for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 09:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLnPW-00080B-2S for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 09:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Feb 2022 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54034 X-GNU-PR-Package: emacs Original-Received: via spool by 54034-submit@debbugs.gnu.org id=B54034.164536806330694 (code B ref 54034); Sun, 20 Feb 2022 14:42:02 +0000 Original-Received: (at 54034) by debbugs.gnu.org; 20 Feb 2022 14:41:03 +0000 Original-Received: from localhost ([127.0.0.1]:59763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLnOZ-0007z0-Cj for submit@debbugs.gnu.org; Sun, 20 Feb 2022 09:41:03 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLnOX-0007yG-I5 for 54034@debbugs.gnu.org; Sun, 20 Feb 2022 09:41:02 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 77E90100189; Sun, 20 Feb 2022 09:40:55 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D03B610012E; Sun, 20 Feb 2022 09:40:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645368053; bh=PhVAnS/MfvYoVp1E2aUsB3yoSZdOlbIgz2/CQmiEb/M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RwC2cQaWxvt79uFSk+ycpiDnLOF/xccUQv6mCUd+iVrFGzkMNXbuMDROEO0nyc+aE Rb9TR2L3+pCRsXboKbPyGrW6AzhX+SJQxcED7vwbw75zzwAQxToOHdsIA1ARZA2x5T cg6FGRVZqavE9AGmNrDAlySKLE0uwvoFJ4AacoqnOWZkC7UBAirqOJfGW6biCcNF1v TNdCEEksIqBcbFgglcfGRBrLTlUYkiZY7KeWZ1srnasVt9NIbGwyYGFcuFjPXGOXIU /oPDBlc+C9/SYH9NNPjlGq2XuvULUGNsopvVRrhIzX/xr3mS4HSpjcRyoB9xaVlGP0 1AkyCQFdKuINQ== Original-Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 83898120811; Sun, 20 Feb 2022 09:40:53 -0500 (EST) In-Reply-To: <87v8xakm0i.fsf@gmail.com> (Matthias Meulien's message of "Sun, 20 Feb 2022 08:58:05 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227246 Archived-At: Matthias Meulien [2022-02-20 08:58:05] wrote: > Matthias Meulien writes: >> When `diff-font-lock-prettify' is non-nil, the fontification of a diff >> where an empty file is added to a Git project is broken: > For binary files, there's an analog problem: One would expect > `diff-font-lock-prettify' to hide the "diff --git", "index", etc. lines > and display a user friendly line. Ah... now I understand: when I looked at your previous email, I couldn't see what you thought was wrong, it all looked correct to me, because what you describe is "not a bug", it's a missing feature ;-) It should be easy to handle those cases as well. Can you suggest a good replacement? (i.e. what should we display instead of the "diff --git ..." stuff) Stefan