unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Matthias Meulien <orontee@gmail.com>
Cc: 54034@debbugs.gnu.org
Subject: bug#54034: 29.0.50; Diff prettify broken for empty files
Date: Sun, 20 Feb 2022 09:40:52 -0500	[thread overview]
Message-ID: <jwvk0dptxio.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87v8xakm0i.fsf@gmail.com> (Matthias Meulien's message of "Sun, 20 Feb 2022 08:58:05 +0100")

Matthias Meulien [2022-02-20 08:58:05] wrote:
> Matthias Meulien <orontee@gmail.com> writes:
>> When `diff-font-lock-prettify' is non-nil, the fontification of a diff
>> where an empty file is added to a Git project is broken:
> For binary files, there's an analog problem: One would expect
> `diff-font-lock-prettify' to hide the "diff --git", "index", etc. lines
> and display a user friendly line.

Ah... now I understand: when I looked at your previous email, I couldn't
see what you thought was wrong, it all looked correct to me, because
what you describe is "not a bug", it's a missing feature ;-)

It should be easy to handle those cases as well.
Can you suggest a good replacement?  (i.e. what should we display
instead of the "diff --git ..." stuff)


        Stefan






  reply	other threads:[~2022-02-20 14:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17  7:47 bug#54034: 29.0.50; Diff prettify broken for empty files Matthias Meulien
2022-02-20  7:58 ` Matthias Meulien
2022-02-20 14:40   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-02-20 16:50     ` Matthias Meulien
2022-02-21 22:23       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-21 23:00         ` Matthias Meulien
2022-02-21 23:10           ` Matthias Meulien
2022-02-21 23:55           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-22  6:58             ` Matthias Meulien
2022-04-06 22:51               ` Matthias Meulien
2022-04-07  7:11                 ` Matthias Meulien
2022-04-07  7:19                   ` Matthias Meulien
2022-04-07 12:15                     ` Matthias Meulien
2022-04-07 20:02                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-08 19:41                         ` Matthias Meulien
2022-06-23 22:36                       ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-29 15:47                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-29 18:04                           ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-29 18:22                           ` Matthias Meulien
2022-06-29 18:55                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-01 18:56                               ` Matthias Meulien
2022-06-29 19:40                             ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-22  7:16             ` Matthias Meulien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk0dptxio.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=54034@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=orontee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).