From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Daniel Mendler <mail@daniel-mendler.de>, 55205@debbugs.gnu.org
Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates
Date: Sun, 01 May 2022 14:34:34 -0400 [thread overview]
Message-ID: <jwvk0b5ayu1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fsltdtzz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 01 May 2022 19:48:16 +0200")
Lars Ingebrigtsen [2022-05-01 19:48:16] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Is there no way to let the text properties survive completion? Because
>>> that's also come up more than a few times.
>> Not sure what you mean by that.
>> I suspect that the details depend a lot on where the completion string
>> comes from. Already the current code's check for
>> `minibuffer-allow-text-properties` seems too coarse since it is used
>> even when the completion is inserted into a normal buffer.
> I mean -- don't alter any of the strings the completion machinery is
> fed, but return them as is.
`completion-replace` doesn't return anything, it just inserts the
string, and as the comment explains, in a common use case that string it
receives includes things like the `completion-first` face which is out
of place at the destination, so there's clearly a need to remove some
properties sometimes. How best to do that of course depends on which
other properties we might want to keep and when.
Stefan
next prev parent reply other threads:[~2022-05-01 18:34 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 8:27 bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Daniel Mendler
2022-05-01 11:53 ` Lars Ingebrigtsen
2022-05-01 12:17 ` Eli Zaretskii
2022-05-01 20:11 ` Dmitry Gutov
2022-05-02 2:23 ` Eli Zaretskii
2022-05-02 9:46 ` Dmitry Gutov
2022-05-02 14:27 ` Eli Zaretskii
2022-05-02 21:06 ` Dmitry Gutov
2022-05-02 16:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 16:24 ` Eli Zaretskii
2022-05-02 16:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 16:38 ` Daniel Mendler
2022-05-02 16:47 ` Eli Zaretskii
2022-05-02 16:43 ` Eli Zaretskii
2022-05-02 16:48 ` Daniel Mendler
2022-05-02 16:53 ` Eli Zaretskii
2022-05-02 16:57 ` Daniel Mendler
2022-05-02 17:53 ` Eli Zaretskii
2022-05-02 18:35 ` Daniel Mendler
2022-05-02 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 12:40 ` Daniel Mendler
2022-05-01 12:49 ` Eli Zaretskii
2022-05-01 12:54 ` Daniel Mendler
2022-05-01 13:16 ` Eli Zaretskii
2022-05-01 13:19 ` Daniel Mendler
2022-05-01 13:21 ` Daniel Mendler
2022-05-01 12:50 ` Daniel Mendler
2022-05-01 17:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 17:26 ` Lars Ingebrigtsen
2022-05-01 17:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 17:48 ` Lars Ingebrigtsen
2022-05-01 18:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-01 18:27 ` Daniel Mendler
2022-05-01 18:39 ` Lars Ingebrigtsen
2022-05-01 19:01 ` Daniel Mendler
2022-05-01 19:07 ` Lars Ingebrigtsen
2022-05-01 20:52 ` Dmitry Gutov
2022-05-01 20:54 ` Lars Ingebrigtsen
2022-05-01 21:30 ` Dmitry Gutov
2022-05-01 21:43 ` Lars Ingebrigtsen
2022-05-02 6:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 8:11 ` Lars Ingebrigtsen
2022-05-02 9:00 ` Daniel Mendler
2022-05-02 12:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-03 10:13 ` Lars Ingebrigtsen
2022-05-03 12:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-04 7:48 ` Lars Ingebrigtsen
2022-05-04 8:24 ` Daniel Mendler
2022-05-04 8:51 ` Daniel Mendler
2022-05-02 8:49 ` Daniel Mendler
2022-05-02 9:04 ` Lars Ingebrigtsen
2022-05-02 9:57 ` Daniel Mendler
2022-05-02 10:07 ` Lars Ingebrigtsen
2022-05-02 10:17 ` Daniel Mendler
2022-05-01 17:39 ` Eli Zaretskii
2022-05-01 18:06 ` Daniel Mendler
2022-05-02 0:34 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk0b5ayu1.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=55205@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).