From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60143: 29.0.60; command `undo-redo` don't restore cursor position Date: Mon, 19 Dec 2022 11:09:09 -0500 Message-ID: References: <83len5ezxs.fsf@gnu.org> <83y1r4dq0a.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5898"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: liuyinz95@gmail.com, 60143@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 19 17:10:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7Iid-0001MO-KK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Dec 2022 17:10:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7IiL-0000He-DD; Mon, 19 Dec 2022 11:10:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7IiI-0000FE-DS for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 11:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7IiI-0004Hf-4L for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 11:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7IiH-0004DT-W8 for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 11:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60143 X-GNU-PR-Package: emacs Original-Received: via spool by 60143-submit@debbugs.gnu.org id=B60143.167146616316170 (code B ref 60143); Mon, 19 Dec 2022 16:10:01 +0000 Original-Received: (at 60143) by debbugs.gnu.org; 19 Dec 2022 16:09:23 +0000 Original-Received: from localhost ([127.0.0.1]:38958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Ihf-0004Ck-64 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 11:09:23 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Ihb-0004CZ-R8 for 60143@debbugs.gnu.org; Mon, 19 Dec 2022 11:09:22 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4E4944415B3; Mon, 19 Dec 2022 11:09:14 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B9E41440340; Mon, 19 Dec 2022 11:09:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671466152; bh=0QsdQhQ1CHwcgzLmqzzxtOV41/8ZxPbY970NEUQoX1g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dy29OtyGQqQaG+RUxaq+M00pl8IT+zA5gEnKkhtRrIvYIEfUVih/1yJtW/Dmq8azZ GJ4COLsDGZ7O/zgHh7r4KinwkU96piU6w8neJqeHOdnn6GGuqbrCnzxU11VpBRSk5F zuoHgSTnpVGYfNDeZgjx1O0MXVOHrRhr1/14zJUvZ944RDdEJ7yKSuHpWXbpRO1lND ES8A4wXpNJ5glHSKbbWOrNcWQeBV774lihMv7A6AoO0Sxce3LwlF8w+Q5fL9zOILFp Q7s8QZH3cEC63W5Jlw32b1qt+Xo8Axkmpcg3FzyHxuRRKkeNur73hbibZqlB3v8A/r ZeN3nS0LkK+4A== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 94CEC12025D; Mon, 19 Dec 2022 11:09:12 -0500 (EST) In-Reply-To: <83y1r4dq0a.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Dec 2022 05:35:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251439 Archived-At: Eli Zaretskii [2022-12-19 05:35:49] wrote: >> From: Stefan Monnier >> Cc: yinz Liu , 60143@debbugs.gnu.org >> Date: Sun, 18 Dec 2022 20:42:31 -0500 >> >> > So I very much hesitate to change this. Stefan, any comments? >> >> Changing that code is likely wrong, indeed. If the undo doesn't get >> you where you expected, it should usually be changed by adding an >> additional record to the undo log. >> >> That "record" is a simple integer indicating the position of point at >> that moment (citing `C-h o buffer-undo-list`): >> >> An entry of the form POSITION indicates that point was at the buffer >> location given by the integer. Undoing an entry of this form places >> point at POSITION. >> >> As for whether we should add such a record in the OP's scenario, and how >> to do that, I haven't looked at his scenario in enough detail to have >> much to say about it. > > I don't think we record position of point before deletion. I think we do, at least sometimes: record_delete (ptrdiff_t beg, Lisp_Object string, bool record_markers) { [...] record_point (beg); -- Stefan