From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?UTF-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= Date: Fri, 07 Jul 2023 12:10:41 -0400 Message-ID: References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> <875y751tsz.fsf@web.de> <83wmzlsd4u.fsf@gnu.org> <83ttuhilpb.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38991"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: michael_heerdegen@web.de, zack@owlfolio.org, 64232-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 18:11:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHo3B-0009z2-TV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 18:11:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHo2z-0003LW-2y; Fri, 07 Jul 2023 12:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHo2w-0003L0-R0 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 12:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHo2w-0000Ta-J4 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 12:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHo2w-0002wz-E0 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 12:11:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jul 2023 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64232 X-GNU-PR-Package: emacs Mail-Followup-To: 64232@debbugs.gnu.org, monnier@iro.umontreal.ca, zack@owlfolio.org Original-Received: via spool by 64232-done@debbugs.gnu.org id=D64232.168874625211319 (code D ref 64232); Fri, 07 Jul 2023 16:11:02 +0000 Original-Received: (at 64232-done) by debbugs.gnu.org; 7 Jul 2023 16:10:52 +0000 Original-Received: from localhost ([127.0.0.1]:43663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHo2m-0002wV-9L for submit@debbugs.gnu.org; Fri, 07 Jul 2023 12:10:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHo2j-0002wG-4D for 64232-done@debbugs.gnu.org; Fri, 07 Jul 2023 12:10:50 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A7DF1802B3; Fri, 7 Jul 2023 12:10:43 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 59177805BA; Fri, 7 Jul 2023 12:10:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688746242; bh=YWHfkmcleS6uB6dQpW+KLS3ngBfxGohVJFWYzhQY+6A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Wa/rTeiv5WvToveHxZOKmqLa9Bn5WOKxpgSVwKht9kJ+dZFnokIX2RRoOL4mLRXhN czwsqiHUzpP8IkzyeyYd0MDaXl7wVeCy7nTcnCEyGwysRuMSRiXVQNv0ojpYw9lUJu ldsTiMUg+CITaX+muyMls749Q89RsEi+KZjBYO6L7HvPqsvX1zeeFaPqlT5Gcl6089 2v5NrLu9y+Eq1KS0QvCWGaUWfQwaOR975vOfjdyNt5JWgmslYrfPaZ48VQ4XxR79oy D++WkFWDf/2YV+BzENJaE1OVL5sZhZai2xslVL68m+bbv47CdtX2wiyNPwrr2asQRi jhmxIrcT5wJaA== Original-Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2C1BE1202DB; Fri, 7 Jul 2023 12:10:42 -0400 (EDT) In-Reply-To: <83ttuhilpb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Jul 2023 09:43:44 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264734 Archived-At: >> > > --- a/lisp/emacs-lisp/bytecomp.el >> > > +++ b/lisp/emacs-lisp/bytecomp.el >> > > @@ -1128,7 +1128,8 @@ byte-compile-eval >> > > ;; we arguably should add it to b-c-noruntime-functions, >> > > ;; but it's not clear it's worth the trouble >> > > ;; trying to recognize that case. >> > > - (unless (get f 'function-history) >> > > + (unless (or (get f 'function-history) >> > > + (assq f byte-compile-function-environment)) >> > > (push f byte-compile-noruntime-functions))))))))))))) >> > >> > Seems appropriate (and fixes this bug). >> > Actually with that patch the situation looks already quite ok'ish to me. >> Please install this on master, and thanks. > Ping! Any reasons this was not yet installed on master? Oops, sorry. Pushed, Stefan