From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char Date: Thu, 07 Sep 2023 12:47:03 -0400 Message-ID: References: <834jk6yqbh.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14927"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Filipp Gunbin , 65805@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 18:48:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeIB0-0003am-QD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 18:48:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeIAk-0002Ip-1o; Thu, 07 Sep 2023 12:48:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeIAj-0002IE-CF for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 12:48:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeIAj-00050Y-4M for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 12:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeIAk-0004BU-85 for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 12:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65805 X-GNU-PR-Package: emacs Original-Received: via spool by 65805-submit@debbugs.gnu.org id=B65805.169410523615920 (code B ref 65805); Thu, 07 Sep 2023 16:48:02 +0000 Original-Received: (at 65805) by debbugs.gnu.org; 7 Sep 2023 16:47:16 +0000 Original-Received: from localhost ([127.0.0.1]:41251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeIA0-00048i-Ay for submit@debbugs.gnu.org; Thu, 07 Sep 2023 12:47:16 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeI9w-00048T-Tb for 65805@debbugs.gnu.org; Thu, 07 Sep 2023 12:47:14 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9879710006B; Thu, 7 Sep 2023 12:47:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694105224; bh=g7zjLdJGrMGsm+Z21qn0A6GTlE37pZ7zSWdVcuHuDp0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=J6EMm4s4tW8Rq5HqdBE2jbsGYtVF5Mx5K73SjSPvXbEtFKhMSHEirX+PRaM4R4dvW nasCBmdwuHKnqiwnqvuHTvc1QEfP9ImzxtJtikNPDU4vccE4UIzCRUJalTq4P/+NhP bk6kSpmPX7daBFP4q5w4vrmRmBeSXAGRkKm50TeFeTE1qzxfqMWUB0DLabsvlsf21J VF4SS1LbdzVFRM0vloN4gH2TMJSd8UHACjgeMDyZGKnkb71jce9Ko+y6WRlf/0LuU1 jnFq/ouc3iVjiWlF5hYP5sfbT9FidykyniaZ+ugSZK6CGQf8zVyvoYoohfgcx8e3oj AK/txYJ0ZIFig== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8F09C100046; Thu, 7 Sep 2023 12:47:04 -0400 (EDT) Original-Received: from pastel (69-165-136-223.dsl.teksavvy.com [69.165.136.223]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 68D71120296; Thu, 7 Sep 2023 12:47:04 -0400 (EDT) In-Reply-To: <834jk6yqbh.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Sep 2023 18:07:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269681 Archived-At: Eli Zaretskii [2023-09-07 18:07:46] wrote: >> From: Filipp Gunbin >> Date: Thu, 07 Sep 2023 17:53:33 +0300 >> >> Hi, I'm not sure this should be treated as bug (and can be fixed), but >> still I find it inconvenient. >> >> - emacs -Q >> - Open new buffer in text mode >> - Type "foo C-q C-i bar" >> - Now, with point at "foo", isearch for tab character works: "C-s C-q C-i" >> - But zap-to-char doesn't: "M-z C-q C-i RET" displays "Wrong answer" > > That's because we switched to using read-from-minibuffer (via > read-char-from-minibuffer) instead of using read-char, for the dubious > benefit of being able to use history in this command, see bug#10477. > And read-from-minibuffer interprets some characters specially. > > Stefan, is there a way to have this cake and eat it, too? How 'bout the patch below? AFAICT it would also make it unnecessary to use `read-char-from-minibuffer-insert-char`. Stefan diff --git a/lisp/subr.el b/lisp/subr.el index 216981eaf31..5b268e9a069 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3733,7 +3733,14 @@ read-char-from-minibuffer read-char-from-minibuffer-map)) ;; Protect this-command when called from pre-command-hook (bug#45029) (this-command this-command) - (result (progn + (result (minibuffer-with-setup-hook + (lambda () + (add-hook 'post-command-hook + (lambda () + (if (= (1+ (minibuffer-prompt-end)) + (point-max)) + (exit-minibuffer))) + 'local)) ;; Disable text conversion if it is enabled. ;; (bug#65370) (when (fboundp 'set-text-conversion-style)