From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70139: [PATCH] Improve key-translate to support removing translations Date: Thu, 04 Apr 2024 09:00:31 -0400 Message-ID: References: <87v850t7nz.fsf@gmail.com> <20240402190246.1824023-1-charmitro@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70139@debbugs.gnu.org To: Charalampos Mitrodimas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 04 15:01:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsMio-0006pr-1h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Apr 2024 15:01:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsMiA-0004Lw-TR; Thu, 04 Apr 2024 09:00:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsMi9-0004L5-8W for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:00:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsMi8-0008Rn-MQ for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:00:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsMiD-00032J-Jk for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2024 13:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70139 X-GNU-PR-Package: emacs Original-Received: via spool by 70139-submit@debbugs.gnu.org id=B70139.171223564711564 (code B ref 70139); Thu, 04 Apr 2024 13:01:01 +0000 Original-Received: (at 70139) by debbugs.gnu.org; 4 Apr 2024 13:00:47 +0000 Original-Received: from localhost ([127.0.0.1]:60802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsMhz-00030S-3x for submit@debbugs.gnu.org; Thu, 04 Apr 2024 09:00:47 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsMhw-0002zT-F8 for 70139@debbugs.gnu.org; Thu, 04 Apr 2024 09:00:45 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BA27980DB3; Thu, 4 Apr 2024 09:00:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1712235632; bh=HrnDVHuuyY7q3nl8VaHC/fG8RySoAKjHGly5/n+8tVU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=mif6rmPBxzpI5rPcj67OMOl0tcnWGZ+k+AT28Ml32EUpHWplHOs5eI7mT1OZRii77 FAGhHN0wtSUHjnMQ2oa2vnsbQ8ijTb7qbMESOXZxLrqbnVaqtM7zHOrYqDykXsKFyi Pv0/0+2wxBX/C6X1EfZqmXpk0ecS+iPeNBITpkPJn7BZ1LxzRnhrWYMxQ/Y1cDRC2X PUsMJLVhxV/yVOdlv03LhMB011WZ97v19Ok/+Ioqeda/GXa615U7A9SWN4ZhWKgM76 v4JSMwJkbGBYEO3aDf26Q5mBCPR+tEczDSZqyt6css8s2tk+IHq0QBTXFpwutBe0vd L6dpcL4pN7RaQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DBD6580136; Thu, 4 Apr 2024 09:00:32 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BABA412030C; Thu, 4 Apr 2024 09:00:32 -0400 (EDT) In-Reply-To: <20240402190246.1824023-1-charmitro@posteo.net> (Charalampos Mitrodimas's message of "Tue, 2 Apr 2024 19:02:46 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282642 Archived-At: I don't have much to say about this bug report or the fix for it, I'm not very familiar with the `keyboard-translate-table` part of our input processing. > (aset keyboard-translate-table > (aref (key-parse from) 0) > - (aref (key-parse to) 0))) > + (and to (aref (key-parse to) 0)))) But here, I think that, in keeping with the tradition of the `key-*` functions, we should signal an error if `key-parse` returns an array longer than 1 element, instead of just using the first element and silently dropping the rest on the floor. Stefan