From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#902: select-active-regions only half-working Date: Wed, 10 Sep 2008 12:37:45 -0400 Message-ID: References: <48C21AD8.1060505@harpegolden.net> <48C2E68C.6060909@harpegolden.net> <48C43937.7030702@harpegolden.net> <48C5C661.4090201@harpegolden.net> <48C6CC6F.5090100@harpegolden.net> Reply-To: Stefan Monnier , 902@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1221065521 25930 80.91.229.12 (10 Sep 2008 16:52:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Sep 2008 16:52:01 +0000 (UTC) Cc: 902@emacsbugs.donarmstrong.com To: David De La Harpe Golden Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 10 18:52:56 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KdSt8-0002JR-5t for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Sep 2008 18:49:54 +0200 Original-Received: from localhost ([127.0.0.1]:44666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdSs8-0007v6-43 for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Sep 2008 12:48:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KdSqz-0007IZ-D4 for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 12:47:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KdSqu-0007DR-UB for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 12:47:38 -0400 Original-Received: from [199.232.76.173] (port=58911 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdSqu-0007DA-9n for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 12:47:36 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:45073) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KdSqt-0002U4-Kq for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 12:47:35 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8AGlWh7019823; Wed, 10 Sep 2008 09:47:33 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m8AGj3C9018448; Wed, 10 Sep 2008 09:45:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 10 Sep 2008 16:45:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 902 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 902-submit@emacsbugs.donarmstrong.com id=B902.122106467816351 (code B ref 902); Wed, 10 Sep 2008 16:45:02 +0000 Original-Received: (at 902) by emacsbugs.donarmstrong.com; 10 Sep 2008 16:37:58 +0000 Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8AGbpm6016345 for <902@emacsbugs.donarmstrong.com>; Wed, 10 Sep 2008 09:37:52 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhwGAFmUx0hFxIqP/2dsb2JhbACBZbcXgWSBBg X-IronPort-AV: E=Sophos;i="4.32,373,1217822400"; d="scan'208";a="26616629" Original-Received: from 69-196-138-143.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 10 Sep 2008 12:37:45 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A61A185E5; Wed, 10 Sep 2008 12:37:45 -0400 (EDT) In-Reply-To: <48C6CC6F.5090100@harpegolden.net> (David De La Harpe Golden's message of "Tue, 09 Sep 2008 20:20:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Wed, 10 Sep 2008 12:47:38 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20439 Archived-At: > + (save-excursion > + (set-buffer value) Aka "(with-current-buffer value". Again, since this code is present at several places, move it into its own function. Basically this function could turn the buffer value into a "cons of markers" value, so you can use it everywhere and reuse the code that handles a cons of markers. Also the select-active-regions docstring shouldn't recommend to turn on transient-mark-mode since it's already ON by default. Stefan