unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: klaus.berndl@capgemini-sdm.com
Cc: 3018@emacsbugs.donarmstrong.com
Subject: bug#3018: clone-indirect-buffer-hook should be make-indirect-buffer-hook
Date: Fri, 17 Apr 2009 16:26:36 -0400	[thread overview]
Message-ID: <jwviql3vxou.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <84D8FEFE8D23E94E9C2A6F0C58EE07E30239ADFA@mucmail3.sdm.de> (klaus berndl's message of "Thu, 16 Apr 2009 17:46:30 +0200")

> IMHO a bug in Emacs 23 because if there is such a hook, then it should
> be used by both of them - at ist best only by make-indirect-buffer
> (because this command is called by clone-indirect-buffer) and then the
> new hook should be named make-indirect-buffer-hook...

If `make-indirect-buffer' is called with a nil argument for `clone',
then it shouldn't run any buffer-local part of
clone-indirect-buffer-hook (which is typically used by major modes).

So maybe you're right, but as long as nobody uses the global part of
clone-indirect-buffer-hook, or calls `make-indirect-buffer' with
a non-nil `clone' argument (rather than calling clone-indirect-buffer),
it shouldn't matter.

Care to explain the context in which you bumped into this?  It might
help us understand what needs to be done.


        Stefan







  parent reply	other threads:[~2009-04-17 20:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 15:46 bug#3018: clone-indirect-buffer-hook should be make-indirect-buffer-hook klaus.berndl
2009-04-17  9:53 ` Lennart Borgman
2009-04-17 20:26 ` Stefan Monnier [this message]
2009-04-18  8:49   ` bug#3018: AW: " klaus.berndl
2009-04-18 12:56     ` bug#3018: Re[1]: " Eric M. Ludlam
2009-04-18 17:54       ` bug#3018: " Stefan Monnier
2009-04-19  4:55         ` bug#3018: AW: " klaus.berndl
2022-05-01 10:00 ` bug#3018: bug#3038: 23.0.91; after-change-functions and indirect buffers Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwviql3vxou.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=3018@emacsbugs.donarmstrong.com \
    --cc=klaus.berndl@capgemini-sdm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).