unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Stephen Berman <stephen.berman@gmx.net>, 8147@debbugs.gnu.org
Subject: bug#8147: 24.0.50; Inserting *Help* buffer can lead to data loss
Date: Mon, 07 Mar 2011 11:20:12 -0500	[thread overview]
Message-ID: <jwvipvuoqdt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k4gct2mc.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 06 Mar 2011 15:28:43 -0500")

> The buffer from you pasted the button might not be *Help*; it could be
> any other buffer in Help mode.  So wouldn't it be inconsistent either
> way?

I don't think that's a problem.  His patch looks good to me.
The main issue is to avoid replacing the buffer's content when that
content is not prepared for such replacement, and help-mode buffers are
supposed to be prepared for it (e.g. proving the help-xref-stack to
"undo").


        Stefan





      parent reply	other threads:[~2011-03-07 16:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 16:02 bug#8147: 24.0.50; Inserting *Help* buffer can lead to data loss Stephen Berman
2011-03-02 17:07 ` Stefan Monnier
2011-03-05 21:10   ` Chong Yidong
2011-03-06  0:24     ` Stephen Berman
2011-03-06 16:38       ` Stephen Berman
2011-03-06 20:28         ` Chong Yidong
2011-03-06 23:41           ` Stephen Berman
2011-03-06 23:58             ` Stephen Berman
2011-03-07 16:20           ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvipvuoqdt.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=8147@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).