unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#8710: 23.3.50; diff-refine-hunk deactivate active region
@ 2011-05-21 13:06 Leo
  2011-05-23 17:04 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Leo @ 2011-05-21 13:06 UTC (permalink / raw)
  To: 8710

1. Make a diff-mode buffer (e.g. from vc-diff)
2. Activate a region
3. Press C-c C-b

Active region deactivated.

This, for example, disallows user to set-mark at the beginning of a hunk
and then M-n to select it.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#8710: 23.3.50; diff-refine-hunk deactivate active region
  2011-05-21 13:06 bug#8710: 23.3.50; diff-refine-hunk deactivate active region Leo
@ 2011-05-23 17:04 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2011-05-23 17:04 UTC (permalink / raw)
  To: Leo; +Cc: 8710-done

Version: 24.1

> 1. Make a diff-mode buffer (e.g. from vc-diff)
> 2. Activate a region
> 3. Press C-c C-b

> Active region deactivated.

Good point.  I've installed the patch below into the trunk, which should
fix it.


        Stefan


--- lisp/vc/smerge-mode.el	2011-05-12 07:07:06 +0000
+++ lisp/vc/smerge-mode.el	2011-05-23 17:01:29 +0000
@@ -991,6 +991,7 @@
 used to replace chars to try and eliminate some spurious differences."
   (let* ((buf (current-buffer))
          (pos (point))
+         deactivate-mark         ; The code does not modify any visible buffer.
          (file1 (make-temp-file "diff1"))
          (file2 (make-temp-file "diff2")))
     ;; Chop up regions into smaller elements and save into files.






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-23 17:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-21 13:06 bug#8710: 23.3.50; diff-refine-hunk deactivate active region Leo
2011-05-23 17:04 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).