unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 8781@debbugs.gnu.org, 8730@debbugs.gnu.org
Subject: bug#8730: bug#8781: bug#8730: bug#8781: 24.0.50; unload-feature don't restore default key
Date: Thu, 02 Jun 2011 09:26:59 -0300	[thread overview]
Message-ID: <jwvipsoju91.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <BANLkTi=PPMKHfG4nN_BXm=0FY=P+LcL0Fw@mail.gmail.com> (Juanma Barranquero's message of "Thu, 2 Jun 2011 13:40:12 +0200")

>>> Try the following patch. It sets [pj]ython-mode buffers to
>>> (default-value 'major-mode), and inferior-python-mode buffers to the
>>> parent of this mode (comint).
>> I guess this part could be part of the generic unload-feature code.
> How can we reliably determine that a symbol represents a major mode
> name?

We don't have to do it for all cases, but recognizing major modes
defined by define-derived-mode is easy: check the
`derived-mode-parent' property.

> Or are you proposing to go through the buffer list and checking
> whether their major modes are defined in the package being unloaded?

Ah, yes, indeed, that's another solution that would work as well.


        Stefan





  reply	other threads:[~2011-06-02 12:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 11:55 bug#8781: 24.0.50; unload-feature don't restore default key Andreas Röhler
2011-06-01 16:27 ` bug#8730: " Juanma Barranquero
2011-06-02  4:11   ` Stefan Monnier
2011-06-02 11:40     ` bug#8730: bug#8781: " Juanma Barranquero
2011-06-02 12:26       ` Stefan Monnier [this message]
2011-06-02 13:59         ` bug#8781: " Juanma Barranquero
2011-06-02 14:26           ` Stefan Monnier
2011-06-23 10:17             ` Juanma Barranquero
2011-06-25 13:30               ` Stefan Monnier
2011-06-25 16:49                 ` bug#8781: " Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvipsoju91.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=8730@debbugs.gnu.org \
    --cc=8781@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).