From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16604: 24.3.50; False negatives in lisp-completion-at-point Date: Sun, 02 Feb 2014 22:48:32 -0500 Message-ID: References: <87d2j8yd12.fsf@yandex.ru> <52EDA4DE.8050904@yandex.ru> <52EDB4B9.9000901@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1391399354 18586 80.91.229.3 (3 Feb 2014 03:49:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Feb 2014 03:49:14 +0000 (UTC) Cc: 16604@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 03 04:49:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WAAXA-00044A-He for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Feb 2014 04:49:20 +0100 Original-Received: from localhost ([::1]:43854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAAXA-0001se-6a for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Feb 2014 22:49:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAAX0-0001sB-BS for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2014 22:49:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAAWs-0006ub-St for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2014 22:49:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAAWs-0006uX-PK for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2014 22:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WAAWs-0001ZR-7l for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2014 22:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Feb 2014 03:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16604-submit@debbugs.gnu.org id=B16604.13913993186003 (code B ref 16604); Mon, 03 Feb 2014 03:49:02 +0000 Original-Received: (at 16604) by debbugs.gnu.org; 3 Feb 2014 03:48:38 +0000 Original-Received: from localhost ([127.0.0.1]:47069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WAAWR-0001Yh-F0 for submit@debbugs.gnu.org; Sun, 02 Feb 2014 22:48:37 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:53643) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WAAWP-0001YZ-HG for 16604@debbugs.gnu.org; Sun, 02 Feb 2014 22:48:34 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpYzZ/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFpYzZ/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="46645073" Original-Received: from 69-165-140-217.dsl.teksavvy.com (HELO pastel.home) ([69.165.140.217]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Feb 2014 22:48:32 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 73DF2619BA; Sun, 2 Feb 2014 22:48:32 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Sun, 02 Feb 2014 21:03:19 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:84499 Archived-At: >> So maybe "merge" is indeed a better default than "in-turn". > I guess it means it might be worth trying to fix it for 24.4. > But your completion-table-merge needs to be improved: the list passed to > the outer `try-completion' needs to only hold strings, whereas the inner > `try-completion's can return nil or t. Also, the outer try-completion could end up returning t if one of the inner ones returns the string we're trying to complete. We might be better off always going through "(apply #'append (mapcar #'all-completions ...))", e.g. via completion-table-dynamic. Also, we should try and check that the sub-tables all have "trivial" boundaries, and no quoting. Stefan