unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eric Hanchrow <eric.hanchrow@gmail.com>
Cc: 17659-done@debbugs.gnu.org
Subject: bug#17659: 24.3.90; C-x 8 ? displays help instead of inserting INVERTED QUESTION MARK
Date: Wed, 18 Jun 2014 23:52:49 -0400	[thread overview]
Message-ID: <jwvionx1rvm.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAHZoxq9ouywjhgk8q_wG+m2v5jxFw55VWdF9wzj2pLFo0xWTZw@mail.gmail.com> (Eric Hanchrow's message of "Sat, 31 May 2014 21:00:12 -0700")

> The subject says it all: when I type C-x 8 ?, I expect emacs to insert
> into the buffer Unicode 191, INVERTED QUESTION MARK.  However, instead
> it displays a *Help* buffer whose first line reads

>         Key translations Starting With C-x 8:

I installed the patch below into emacs-24 which seems to fix this problem.


        Stefan


=== modified file 'src/keyboard.c'
--- src/keyboard.c	2014-05-06 16:16:57 +0000
+++ src/keyboard.c	2014-06-19 03:30:12 +0000
@@ -9384,16 +9385,6 @@
 	  first_unbound = min (t, first_unbound);
 
 	  head = EVENT_HEAD (key);
-	  if (help_char_p (head) && t > 0)
-	    {
-	      read_key_sequence_cmd = Vprefix_help_command;
-	      keybuf[t++] = key;
-	      last_nonmenu_event = key;
-	      /* The Microsoft C compiler can't handle the goto that
-		 would go here.  */
-	      dummyflag = 1;
-	      break;
-	    }
 
 	  if (SYMBOLP (head))
 	    {
@@ -9651,6 +9642,17 @@
 
 	  goto replay_sequence;
 	}
+
+      if (NILP (current_binding)
+	  && help_char_p (EVENT_HEAD (key)) && t > 1)
+	    {
+	      read_key_sequence_cmd = Vprefix_help_command;
+	      /* The Microsoft C compiler can't handle the goto that
+		 would go here.  */
+	      dummyflag = 1;
+	      break;
+	    }
+
       /* If KEY is not defined in any of the keymaps,
 	 and cannot be part of a function key or translation,
 	 and is a shifted function key,






      parent reply	other threads:[~2014-06-19  3:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-01  4:00 bug#17659: 24.3.90; C-x 8 ? displays help instead of inserting INVERTED QUESTION MARK Eric Hanchrow
2014-06-02 13:01 ` Leo Liu
2014-06-03  1:52   ` Stefan Monnier
2014-06-03  2:58     ` Leo Liu
2014-06-04  0:02       ` Leo Liu
2014-06-04 12:33         ` Stefan Monnier
2014-06-19  3:33   ` Stefan Monnier
2014-06-19  4:23     ` Leo Liu
2014-06-19 13:32     ` Drew Adams
2014-06-19  3:52 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvionx1rvm.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17659-done@debbugs.gnu.org \
    --cc=eric.hanchrow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).