From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17549: 24.4.50; regression: url-insert-file-contents Date: Wed, 25 Jun 2014 22:38:37 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1403750369 26297 80.91.229.3 (26 Jun 2014 02:39:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Jun 2014 02:39:29 +0000 (UTC) Cc: 17549@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 26 04:39:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wzzar-0007qG-Qb for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jun 2014 04:39:21 +0200 Original-Received: from localhost ([::1]:41954 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzzar-0005Kd-4X for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jun 2014 22:39:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzzag-0005Jf-SU for bug-gnu-emacs@gnu.org; Wed, 25 Jun 2014 22:39:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzzaZ-0003io-DW for bug-gnu-emacs@gnu.org; Wed, 25 Jun 2014 22:39:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzzaZ-0003ik-9x for bug-gnu-emacs@gnu.org; Wed, 25 Jun 2014 22:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WzzaY-0003eD-K6 for bug-gnu-emacs@gnu.org; Wed, 25 Jun 2014 22:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jun 2014 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17549 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17549-submit@debbugs.gnu.org id=B17549.140375032713986 (code B ref 17549); Thu, 26 Jun 2014 02:39:02 +0000 Original-Received: (at 17549) by debbugs.gnu.org; 26 Jun 2014 02:38:47 +0000 Original-Received: from localhost ([127.0.0.1]:60976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzzaJ-0003dU-3h for submit@debbugs.gnu.org; Wed, 25 Jun 2014 22:38:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:45489) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzzaF-0003d7-Qg for 17549@debbugs.gnu.org; Wed, 25 Jun 2014 22:38:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArcGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw+9L4MOgRcXdIImAQEEViMQCw4mEhQYDSSIDNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArcGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw+9L4MOgRcXdIImAQEEViMQCw4mEhQYDSSIDNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="69587935" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Jun 2014 22:38:37 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 92B5266302; Wed, 25 Jun 2014 22:38:37 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Thu, 26 Jun 2014 08:19:49 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90824 Archived-At: > +(defconst url-http-codes) This should use `defvar'. > - (let ((response (url-http-parse-response))) > - (if (and (>= response 200) (< response 300)) > - (goto-char (point-min)) > - (let ((desc (buffer-substring-no-properties (1+ (point)) > - (line-end-position)))) > + (when (bound-and-true-p url-http-response-status) > + (unless (and (>= url-http-response-status 200) > + (< url-http-response-status 300)) > + (let ((desc (nth 2 (assq url-http-response-status url-http-codes)))) IIUC the above just adds a "(when (bound-and-true-p url-http-response-status)" wrapper around the existing code, right? If so, it looks like a safe enough fix to install it in emacs-24. This still doesn't look like The Right Way to do things in URL. I think The Right Way would be for the url-http code to set some backend-agnostic properties which url-handlers.el can then use. Stefan